Quellcode durchsuchen

Allow IPv4 and IPv6 addresses in SOCKS5 FQDN requests.

Supposedly there are a decent number of applications that "support"
IPv6 and SOCKS5 using the FQDN address type.  While said applications
should be using the IPv6 address type, allow the connection if
SafeSocks is not set.

Bug not in any released version.
Yawning Angel vor 9 Jahren
Ursprung
Commit
d87d4183ee
1 geänderte Dateien mit 1 neuen und 3 gelöschten Zeilen
  1. 1 3
      src/or/buffers.c

+ 1 - 3
src/or/buffers.c

@@ -2063,9 +2063,7 @@ parse_socks(const char *data, size_t datalen, socks_request_t *req,
               socks_request_set_socks5_error(req, SOCKS5_NOT_ALLOWED);
               return -1;
             }
-          }
-
-          if (!string_is_valid_hostname(req->address)) {
+          } else if (!string_is_valid_hostname(req->address)) {
             socks_request_set_socks5_error(req, SOCKS5_GENERAL_ERROR);
 
             log_warn(LD_PROTOCOL,