Browse Source

Replace incorrect use of snprintf in unit tests with tor_snprintf

This avoids a potential out of bounds write.
teor (Tim Wilson-Brown) 8 years ago
parent
commit
e3da5ad6e3
1 changed files with 3 additions and 2 deletions
  1. 3 2
      src/test/test_tortls.c

+ 3 - 2
src/test/test_tortls.c

@@ -1808,9 +1808,10 @@ test_tortls_debug_state_callback(void *ignored)
 
   tor_tls_debug_state_callback(ssl, 32, 45);
 
-  n = snprintf(buf, 1000, "SSL %p is now in state unknown"
+  n = tor_snprintf(buf, 1000, "SSL %p is now in state unknown"
                " state [type=32,val=45].\n", ssl);
-  buf[n]='\0';
+  /* tor's snprintf returns -1 on error */
+  tt_int_op(n, OP_NE, -1);
   expect_log_msg(buf);
 
  done: