Merge remote-tracking branch 'public/bug8377' into maint-0.2.3

changes/bug8377

@@ -0,0 +1,3 @@
+  o Minor bugfixes:
+    - Correctly recognize that [::1] is a loopback address. Fixes bug #8377;
+      bugfix on 0.2.1.3-alpha.

src/common/address.c

@@ -779,7 +779,8 @@ tor_addr_is_loopback(const tor_addr_t *addr)
     case AF_INET6: {
       /* ::1 */
       uint32_t *a32 = tor_addr_to_in6_addr32(addr);
-      return (a32[0] == 0) && (a32[1] == 0) && (a32[2] == 0) && (a32[3] == 1);
+      return (a32[0] == 0) && (a32[1] == 0) && (a32[2] == 0) &&
+        (ntohl(a32[3]) == 1);
     }
     case AF_INET:
       /* 127.0.0.1 */

src/test/test_addr.c

@@ -623,12 +623,48 @@ test_addr_ip6_helpers(void)
   ;
 }
 
+static void
+test_addr_is_loopback(void *data)
+{
+  static const struct loopback_item {
+    const char *name;
+    int is_loopback;
+  } loopback_items[] = {
+    { "::1", 1 },
+    { "127.0.0.1", 1 },
+    { "127.99.100.101", 1 },
+    { "128.99.100.101", 0 },
+    { "8.8.8.8", 0 },
+    { "0.0.0.0", 0 },
+    { "::2", 0 },
+    { "::", 0 },
+    { "::1.0.0.0", 0 },
+    { NULL, 0 }
+  };
+
+  int i;
+  tor_addr_t addr;
+  (void)data;
+
+  for (i=0; loopback_items[i].name; ++i) {
+    tt_int_op(tor_addr_parse(&addr, loopback_items[i].name), >=, 0);
+    tt_int_op(tor_addr_is_loopback(&addr), ==, loopback_items[i].is_loopback);
+  }
+
+  tor_addr_make_unspec(&addr);
+  tt_int_op(tor_addr_is_loopback(&addr), ==, 0);
+
+ done:
+  ;
+}
+
 #define ADDR_LEGACY(name)                                               \
   { #name, legacy_test_helper, 0, &legacy_setup, test_addr_ ## name }
 
 struct testcase_t addr_tests[] = {
   ADDR_LEGACY(basic),
   ADDR_LEGACY(ip6_helpers),
+  { "is_loopback", test_addr_is_loopback, 0, NULL, NULL },
   END_OF_TESTCASES
 };