123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894 |
- /* Copyright (c) 2016-2017, The Tor Project, Inc. */
- /* See LICENSE for licensing information */
- /**
- * \file test_hs_descriptor.c
- * \brief Test hidden service descriptor encoding and decoding.
- */
- #define HS_DESCRIPTOR_PRIVATE
- #include "crypto_ed25519.h"
- #include "ed25519_cert.h"
- #include "or.h"
- #include "hs_descriptor.h"
- #include "test.h"
- #include "torcert.h"
- #include "hs_test_helpers.h"
- #include "test_helpers.h"
- #include "log_test_helpers.h"
- #ifdef HAVE_CFLAG_WOVERLENGTH_STRINGS
- DISABLE_GCC_WARNING(overlength-strings)
- /* We allow huge string constants in the unit tests, but not in the code
- * at large. */
- #endif
- #include "test_hs_descriptor.inc"
- ENABLE_GCC_WARNING(overlength-strings)
- /* Test certificate encoding put in a descriptor. */
- static void
- test_cert_encoding(void *arg)
- {
- int ret;
- char *encoded = NULL;
- time_t now = time(NULL);
- ed25519_keypair_t kp;
- ed25519_public_key_t signed_key;
- ed25519_secret_key_t secret_key;
- tor_cert_t *cert = NULL;
- (void) arg;
- ret = ed25519_keypair_generate(&kp, 0);
- tt_int_op(ret, == , 0);
- ret = ed25519_secret_key_generate(&secret_key, 0);
- tt_int_op(ret, == , 0);
- ret = ed25519_public_key_generate(&signed_key, &secret_key);
- tt_int_op(ret, == , 0);
- cert = tor_cert_create(&kp, CERT_TYPE_SIGNING_AUTH, &signed_key,
- now, 3600 * 2, CERT_FLAG_INCLUDE_SIGNING_KEY);
- tt_assert(cert);
- /* Test the certificate encoding function. */
- ret = tor_cert_encode_ed22519(cert, &encoded);
- tt_int_op(ret, OP_EQ, 0);
- /* Validated the certificate string. */
- {
- char *end, *pos = encoded;
- char *b64_cert, buf[256];
- size_t b64_cert_len;
- tor_cert_t *parsed_cert;
- tt_int_op(strcmpstart(pos, "-----BEGIN ED25519 CERT-----\n"), OP_EQ, 0);
- pos += strlen("-----BEGIN ED25519 CERT-----\n");
- /* Isolate the base64 encoded certificate and try to decode it. */
- end = strstr(pos, "-----END ED25519 CERT-----");
- tt_assert(end);
- b64_cert = pos;
- b64_cert_len = end - pos;
- ret = base64_decode(buf, sizeof(buf), b64_cert, b64_cert_len);
- tt_int_op(ret, OP_GT, 0);
- /* Parseable? */
- parsed_cert = tor_cert_parse((uint8_t *) buf, ret);
- tt_assert(parsed_cert);
- /* Signature is valid? */
- ret = tor_cert_checksig(parsed_cert, &kp.pubkey, now + 10);
- tt_int_op(ret, OP_EQ, 0);
- ret = tor_cert_eq(cert, parsed_cert);
- tt_int_op(ret, OP_EQ, 1);
- /* The cert did have the signing key? */
- ret= ed25519_pubkey_eq(&parsed_cert->signing_key, &kp.pubkey);
- tt_int_op(ret, OP_EQ, 1);
- tor_cert_free(parsed_cert);
- /* Get to the end part of the certificate. */
- pos += b64_cert_len;
- tt_int_op(strcmpstart(pos, "-----END ED25519 CERT-----"), OP_EQ, 0);
- pos += strlen("-----END ED25519 CERT-----");
- }
- done:
- tor_cert_free(cert);
- tor_free(encoded);
- }
- /* Test the descriptor padding. */
- static void
- test_descriptor_padding(void *arg)
- {
- char *plaintext;
- size_t plaintext_len, padded_len;
- uint8_t *padded_plaintext = NULL;
- /* Example: if l = 129, the ceiled division gives 2 and then multiplied by 128
- * to give 256. With l = 127, ceiled division gives 1 then times 128. */
- #define PADDING_EXPECTED_LEN(l) \
- CEIL_DIV(l, HS_DESC_SUPERENC_PLAINTEXT_PAD_MULTIPLE) * \
- HS_DESC_SUPERENC_PLAINTEXT_PAD_MULTIPLE
- (void) arg;
- { /* test #1: no padding */
- plaintext_len = HS_DESC_SUPERENC_PLAINTEXT_PAD_MULTIPLE;
- plaintext = tor_malloc(plaintext_len);
- padded_len = build_plaintext_padding(plaintext, plaintext_len,
- &padded_plaintext);
- tt_assert(padded_plaintext);
- tor_free(plaintext);
- /* Make sure our padding has been zeroed. */
- tt_int_op(tor_mem_is_zero((char *) padded_plaintext + plaintext_len,
- padded_len - plaintext_len), OP_EQ, 1);
- tor_free(padded_plaintext);
- /* Never never have a padded length smaller than the plaintext. */
- tt_int_op(padded_len, OP_GE, plaintext_len);
- tt_int_op(padded_len, OP_EQ, PADDING_EXPECTED_LEN(plaintext_len));
- }
- { /* test #2: one byte padding? */
- plaintext_len = HS_DESC_SUPERENC_PLAINTEXT_PAD_MULTIPLE - 1;
- plaintext = tor_malloc(plaintext_len);
- padded_plaintext = NULL;
- padded_len = build_plaintext_padding(plaintext, plaintext_len,
- &padded_plaintext);
- tt_assert(padded_plaintext);
- tor_free(plaintext);
- /* Make sure our padding has been zeroed. */
- tt_int_op(tor_mem_is_zero((char *) padded_plaintext + plaintext_len,
- padded_len - plaintext_len), OP_EQ, 1);
- tor_free(padded_plaintext);
- /* Never never have a padded length smaller than the plaintext. */
- tt_int_op(padded_len, OP_GE, plaintext_len);
- tt_int_op(padded_len, OP_EQ, PADDING_EXPECTED_LEN(plaintext_len));
- }
- { /* test #3: Lots more bytes of padding? */
- plaintext_len = HS_DESC_SUPERENC_PLAINTEXT_PAD_MULTIPLE + 1;
- plaintext = tor_malloc(plaintext_len);
- padded_plaintext = NULL;
- padded_len = build_plaintext_padding(plaintext, plaintext_len,
- &padded_plaintext);
- tt_assert(padded_plaintext);
- tor_free(plaintext);
- /* Make sure our padding has been zeroed. */
- tt_int_op(tor_mem_is_zero((char *) padded_plaintext + plaintext_len,
- padded_len - plaintext_len), OP_EQ, 1);
- tor_free(padded_plaintext);
- /* Never never have a padded length smaller than the plaintext. */
- tt_int_op(padded_len, OP_GE, plaintext_len);
- tt_int_op(padded_len, OP_EQ, PADDING_EXPECTED_LEN(plaintext_len));
- }
- done:
- return;
- }
- static void
- test_link_specifier(void *arg)
- {
- ssize_t ret;
- hs_desc_link_specifier_t spec;
- smartlist_t *link_specifiers = smartlist_new();
- (void) arg;
- /* Always this port. */
- spec.u.ap.port = 42;
- smartlist_add(link_specifiers, &spec);
- /* Test IPv4 for starter. */
- {
- char *b64, buf[256];
- uint32_t ipv4;
- link_specifier_t *ls;
- spec.type = LS_IPV4;
- ret = tor_addr_parse(&spec.u.ap.addr, "1.2.3.4");
- tt_int_op(ret, OP_EQ, AF_INET);
- b64 = encode_link_specifiers(link_specifiers);
- tt_assert(b64);
- /* Decode it and validate the format. */
- ret = base64_decode(buf, sizeof(buf), b64, strlen(b64));
- tt_int_op(ret, OP_GT, 0);
- /* First byte is the number of link specifier. */
- tt_int_op(get_uint8(buf), OP_EQ, 1);
- ret = link_specifier_parse(&ls, (uint8_t *) buf + 1, ret - 1);
- tt_int_op(ret, OP_EQ, 8);
- /* Should be 2 bytes for port and 4 bytes for IPv4. */
- tt_int_op(link_specifier_get_ls_len(ls), OP_EQ, 6);
- ipv4 = link_specifier_get_un_ipv4_addr(ls);
- tt_int_op(tor_addr_to_ipv4h(&spec.u.ap.addr), OP_EQ, ipv4);
- tt_int_op(link_specifier_get_un_ipv4_port(ls), OP_EQ, spec.u.ap.port);
- link_specifier_free(ls);
- tor_free(b64);
- }
- /* Test IPv6. */
- {
- char *b64, buf[256];
- uint8_t ipv6[16];
- link_specifier_t *ls;
- spec.type = LS_IPV6;
- ret = tor_addr_parse(&spec.u.ap.addr, "[1:2:3:4::]");
- tt_int_op(ret, OP_EQ, AF_INET6);
- b64 = encode_link_specifiers(link_specifiers);
- tt_assert(b64);
- /* Decode it and validate the format. */
- ret = base64_decode(buf, sizeof(buf), b64, strlen(b64));
- tt_int_op(ret, OP_GT, 0);
- /* First byte is the number of link specifier. */
- tt_int_op(get_uint8(buf), OP_EQ, 1);
- ret = link_specifier_parse(&ls, (uint8_t *) buf + 1, ret - 1);
- tt_int_op(ret, OP_EQ, 20);
- /* Should be 2 bytes for port and 16 bytes for IPv6. */
- tt_int_op(link_specifier_get_ls_len(ls), OP_EQ, 18);
- for (unsigned int i = 0; i < sizeof(ipv6); i++) {
- ipv6[i] = link_specifier_get_un_ipv6_addr(ls, i);
- }
- tt_mem_op(tor_addr_to_in6_addr8(&spec.u.ap.addr), OP_EQ, ipv6,
- sizeof(ipv6));
- tt_int_op(link_specifier_get_un_ipv6_port(ls), OP_EQ, spec.u.ap.port);
- link_specifier_free(ls);
- tor_free(b64);
- }
- /* Test legacy. */
- {
- char *b64, buf[256];
- uint8_t *id;
- link_specifier_t *ls;
- spec.type = LS_LEGACY_ID;
- memset(spec.u.legacy_id, 'Y', sizeof(spec.u.legacy_id));
- b64 = encode_link_specifiers(link_specifiers);
- tt_assert(b64);
- /* Decode it and validate the format. */
- ret = base64_decode(buf, sizeof(buf), b64, strlen(b64));
- tt_int_op(ret, OP_GT, 0);
- /* First byte is the number of link specifier. */
- tt_int_op(get_uint8(buf), OP_EQ, 1);
- ret = link_specifier_parse(&ls, (uint8_t *) buf + 1, ret - 1);
- /* 20 bytes digest + 1 byte type + 1 byte len. */
- tt_int_op(ret, OP_EQ, 22);
- tt_int_op(link_specifier_getlen_un_legacy_id(ls), OP_EQ, DIGEST_LEN);
- /* Digest length is 20 bytes. */
- tt_int_op(link_specifier_get_ls_len(ls), OP_EQ, DIGEST_LEN);
- id = link_specifier_getarray_un_legacy_id(ls);
- tt_mem_op(spec.u.legacy_id, OP_EQ, id, DIGEST_LEN);
- link_specifier_free(ls);
- tor_free(b64);
- }
- done:
- smartlist_free(link_specifiers);
- }
- static void
- test_encode_descriptor(void *arg)
- {
- int ret;
- char *encoded = NULL;
- ed25519_keypair_t signing_kp;
- hs_descriptor_t *desc = NULL;
- (void) arg;
- ret = ed25519_keypair_generate(&signing_kp, 0);
- tt_int_op(ret, OP_EQ, 0);
- desc = hs_helper_build_hs_desc_with_ip(&signing_kp);
- ret = hs_desc_encode_descriptor(desc, &signing_kp, &encoded);
- tt_int_op(ret, OP_EQ, 0);
- tt_assert(encoded);
- done:
- hs_descriptor_free(desc);
- tor_free(encoded);
- }
- static void
- test_decode_descriptor(void *arg)
- {
- int ret;
- char *encoded = NULL;
- ed25519_keypair_t signing_kp;
- hs_descriptor_t *desc = NULL;
- hs_descriptor_t *decoded = NULL;
- hs_descriptor_t *desc_no_ip = NULL;
- uint8_t subcredential[DIGEST256_LEN];
- (void) arg;
- ret = ed25519_keypair_generate(&signing_kp, 0);
- tt_int_op(ret, OP_EQ, 0);
- desc = hs_helper_build_hs_desc_with_ip(&signing_kp);
- hs_helper_get_subcred_from_identity_keypair(&signing_kp,
- subcredential);
- /* Give some bad stuff to the decoding function. */
- ret = hs_desc_decode_descriptor("hladfjlkjadf", subcredential, &decoded);
- tt_int_op(ret, OP_EQ, -1);
- ret = hs_desc_encode_descriptor(desc, &signing_kp, &encoded);
- tt_int_op(ret, OP_EQ, 0);
- tt_assert(encoded);
- ret = hs_desc_decode_descriptor(encoded, subcredential, &decoded);
- tt_int_op(ret, OP_EQ, 0);
- tt_assert(decoded);
- hs_helper_desc_equal(desc, decoded);
- /* Decode a descriptor with _no_ introduction points. */
- {
- ed25519_keypair_t signing_kp_no_ip;
- ret = ed25519_keypair_generate(&signing_kp_no_ip, 0);
- tt_int_op(ret, OP_EQ, 0);
- hs_helper_get_subcred_from_identity_keypair(&signing_kp_no_ip,
- subcredential);
- desc_no_ip = hs_helper_build_hs_desc_no_ip(&signing_kp_no_ip);
- tt_assert(desc_no_ip);
- tor_free(encoded);
- ret = hs_desc_encode_descriptor(desc_no_ip, &signing_kp_no_ip, &encoded);
- tt_int_op(ret, OP_EQ, 0);
- tt_assert(encoded);
- hs_descriptor_free(decoded);
- ret = hs_desc_decode_descriptor(encoded, subcredential, &decoded);
- tt_int_op(ret, OP_EQ, 0);
- tt_assert(decoded);
- }
- done:
- hs_descriptor_free(desc);
- hs_descriptor_free(desc_no_ip);
- hs_descriptor_free(decoded);
- tor_free(encoded);
- }
- static void
- test_supported_version(void *arg)
- {
- int ret;
- (void) arg;
- /* Unsupported. */
- ret = hs_desc_is_supported_version(42);
- tt_int_op(ret, OP_EQ, 0);
- /* To early. */
- ret = hs_desc_is_supported_version(HS_DESC_SUPPORTED_FORMAT_VERSION_MIN - 1);
- tt_int_op(ret, OP_EQ, 0);
- /* One too new. */
- ret = hs_desc_is_supported_version(HS_DESC_SUPPORTED_FORMAT_VERSION_MAX + 1);
- tt_int_op(ret, OP_EQ, 0);
- /* Valid version. */
- ret = hs_desc_is_supported_version(3);
- tt_int_op(ret, OP_EQ, 1);
- done:
- ;
- }
- static void
- test_encrypted_data_len(void *arg)
- {
- int ret;
- size_t value;
- (void) arg;
- /* No length, error. */
- ret = encrypted_data_length_is_valid(0);
- tt_int_op(ret, OP_EQ, 0);
- /* Valid value. */
- value = HS_DESC_ENCRYPTED_SALT_LEN + DIGEST256_LEN + 1;
- ret = encrypted_data_length_is_valid(value);
- tt_int_op(ret, OP_EQ, 1);
- done:
- ;
- }
- static void
- test_decode_invalid_intro_point(void *arg)
- {
- int ret;
- char *encoded_ip = NULL;
- size_t len_out;
- hs_desc_intro_point_t *ip = NULL;
- ed25519_keypair_t signing_kp;
- hs_descriptor_t *desc = NULL;
- (void) arg;
- /* Seperate pieces of a valid encoded introduction point. */
- const char *intro_point =
- "introduction-point AQIUMDI5OUYyNjhGQ0E5RDU1Q0QxNTc=";
- const char *auth_key =
- "auth-key\n"
- "-----BEGIN ED25519 CERT-----\n"
- "AQkACOhAAQW8ltYZMIWpyrfyE/b4Iyi8CNybCwYs6ADk7XfBaxsFAQAgBAD3/BE4\n"
- "XojGE/N2bW/wgnS9r2qlrkydGyuCKIGayYx3haZ39LD4ZTmSMRxwmplMAqzG/XNP\n"
- "0Kkpg4p2/VnLFJRdU1SMFo1lgQ4P0bqw7Tgx200fulZ4KUM5z5V7m+a/mgY=\n"
- "-----END ED25519 CERT-----";
- const char *enc_key =
- "enc-key ntor bpZKLsuhxP6woDQ3yVyjm5gUKSk7RjfAijT2qrzbQk0=";
- const char *enc_key_cert =
- "enc-key-cert\n"
- "-----BEGIN ED25519 CERT-----\n"
- "AQsACOhZAUpNvCZ1aJaaR49lS6MCdsVkhVGVrRqoj0Y2T4SzroAtAQAgBABFOcGg\n"
- "lbTt1DF5nKTE/gU3Fr8ZtlCIOhu1A+F5LM7fqCUupfesg0KTHwyIZOYQbJuM5/he\n"
- "/jDNyLy9woPJdjkxywaY2RPUxGjLYtMQV0E8PUxWyICV+7y52fTCYaKpYQw=\n"
- "-----END ED25519 CERT-----";
- /* Try to decode a junk string. */
- {
- hs_descriptor_free(desc);
- desc = NULL;
- ret = ed25519_keypair_generate(&signing_kp, 0);
- tt_int_op(ret, OP_EQ, 0);
- desc = hs_helper_build_hs_desc_with_ip(&signing_kp);
- const char *junk = "this is not a descriptor";
- ip = decode_introduction_point(desc, junk);
- tt_ptr_op(ip, OP_EQ, NULL);
- hs_desc_intro_point_free(ip);
- ip = NULL;
- }
- /* Invalid link specifiers. */
- {
- smartlist_t *lines = smartlist_new();
- const char *bad_line = "introduction-point blah";
- smartlist_add(lines, (char *) bad_line);
- smartlist_add(lines, (char *) auth_key);
- smartlist_add(lines, (char *) enc_key);
- smartlist_add(lines, (char *) enc_key_cert);
- encoded_ip = smartlist_join_strings(lines, "\n", 0, &len_out);
- tt_assert(encoded_ip);
- ip = decode_introduction_point(desc, encoded_ip);
- tt_ptr_op(ip, OP_EQ, NULL);
- tor_free(encoded_ip);
- smartlist_free(lines);
- hs_desc_intro_point_free(ip);
- ip = NULL;
- }
- /* Invalid auth key type. */
- {
- smartlist_t *lines = smartlist_new();
- /* Try to put a valid object that our tokenize function will be able to
- * parse but that has nothing to do with the auth_key. */
- const char *bad_line =
- "auth-key\n"
- "-----BEGIN UNICORN CERT-----\n"
- "MIGJAoGBAO4bATcW8kW4h6RQQAKEgg+aXCpF4JwbcO6vGZtzXTDB+HdPVQzwqkbh\n"
- "XzFM6VGArhYw4m31wcP1Z7IwULir7UMnAFd7Zi62aYfU6l+Y1yAoZ1wzu1XBaAMK\n"
- "ejpwQinW9nzJn7c2f69fVke3pkhxpNdUZ+vplSA/l9iY+y+v+415AgMBAAE=\n"
- "-----END UNICORN CERT-----";
- /* Build intro point text. */
- smartlist_add(lines, (char *) intro_point);
- smartlist_add(lines, (char *) bad_line);
- smartlist_add(lines, (char *) enc_key);
- smartlist_add(lines, (char *) enc_key_cert);
- encoded_ip = smartlist_join_strings(lines, "\n", 0, &len_out);
- tt_assert(encoded_ip);
- ip = decode_introduction_point(desc, encoded_ip);
- tt_ptr_op(ip, OP_EQ, NULL);
- tor_free(encoded_ip);
- smartlist_free(lines);
- }
- /* Invalid enc-key. */
- {
- smartlist_t *lines = smartlist_new();
- const char *bad_line =
- "enc-key unicorn bpZKLsuhxP6woDQ3yVyjm5gUKSk7RjfAijT2qrzbQk0=";
- /* Build intro point text. */
- smartlist_add(lines, (char *) intro_point);
- smartlist_add(lines, (char *) auth_key);
- smartlist_add(lines, (char *) bad_line);
- smartlist_add(lines, (char *) enc_key_cert);
- encoded_ip = smartlist_join_strings(lines, "\n", 0, &len_out);
- tt_assert(encoded_ip);
- ip = decode_introduction_point(desc, encoded_ip);
- tt_ptr_op(ip, OP_EQ, NULL);
- tor_free(encoded_ip);
- smartlist_free(lines);
- }
- /* Invalid enc-key object. */
- {
- smartlist_t *lines = smartlist_new();
- const char *bad_line = "enc-key ntor";
- /* Build intro point text. */
- smartlist_add(lines, (char *) intro_point);
- smartlist_add(lines, (char *) auth_key);
- smartlist_add(lines, (char *) bad_line);
- smartlist_add(lines, (char *) enc_key_cert);
- encoded_ip = smartlist_join_strings(lines, "\n", 0, &len_out);
- tt_assert(encoded_ip);
- ip = decode_introduction_point(desc, encoded_ip);
- tt_ptr_op(ip, OP_EQ, NULL);
- tor_free(encoded_ip);
- smartlist_free(lines);
- }
- /* Invalid enc-key base64 curv25519 key. */
- {
- smartlist_t *lines = smartlist_new();
- const char *bad_line = "enc-key ntor blah===";
- /* Build intro point text. */
- smartlist_add(lines, (char *) intro_point);
- smartlist_add(lines, (char *) auth_key);
- smartlist_add(lines, (char *) bad_line);
- smartlist_add(lines, (char *) enc_key_cert);
- encoded_ip = smartlist_join_strings(lines, "\n", 0, &len_out);
- tt_assert(encoded_ip);
- ip = decode_introduction_point(desc, encoded_ip);
- tt_ptr_op(ip, OP_EQ, NULL);
- tor_free(encoded_ip);
- smartlist_free(lines);
- }
- /* Invalid enc-key invalid legacy. */
- {
- smartlist_t *lines = smartlist_new();
- const char *bad_line = "legacy-key blah===";
- /* Build intro point text. */
- smartlist_add(lines, (char *) intro_point);
- smartlist_add(lines, (char *) auth_key);
- smartlist_add(lines, (char *) bad_line);
- smartlist_add(lines, (char *) enc_key_cert);
- encoded_ip = smartlist_join_strings(lines, "\n", 0, &len_out);
- tt_assert(encoded_ip);
- ip = decode_introduction_point(desc, encoded_ip);
- tt_ptr_op(ip, OP_EQ, NULL);
- tor_free(encoded_ip);
- smartlist_free(lines);
- }
- done:
- hs_descriptor_free(desc);
- hs_desc_intro_point_free(ip);
- }
- /** Make sure we fail gracefully when decoding the bad desc from #23233. */
- static void
- test_decode_bad_signature(void *arg)
- {
- hs_desc_plaintext_data_t desc_plaintext;
- int ret;
- (void) arg;
- /* Update approx time to dodge cert expiration */
- update_approx_time(1502661599);
- setup_full_capture_of_logs(LOG_WARN);
- ret = hs_desc_decode_plaintext(HS_DESC_BAD_SIG, &desc_plaintext);
- tt_int_op(ret, OP_EQ, -1);
- expect_log_msg_containing("Malformed signature line. Rejecting.");
- teardown_capture_of_logs();
- done:
- desc_plaintext_data_free_contents(&desc_plaintext);
- }
- static void
- test_decode_plaintext(void *arg)
- {
- int ret;
- hs_desc_plaintext_data_t desc_plaintext;
- const char *bad_value = "unicorn";
- (void) arg;
- #define template \
- "hs-descriptor %s\n" \
- "descriptor-lifetime %s\n" \
- "descriptor-signing-key-cert\n" \
- "-----BEGIN ED25519 CERT-----\n" \
- "AQgABjvPAQaG3g+dc6oV/oJV4ODAtkvx56uBnPtBT9mYVuHVOhn7AQAgBABUg3mQ\n" \
- "myBr4bu5LCr53wUEbW2EXui01CbUgU7pfo9LvJG3AcXRojj6HlfsUs9BkzYzYdjF\n" \
- "A69Apikgu0ewHYkFFASt7Il+gB3w6J8YstQJZT7dtbtl+doM7ug8B68Qdg8=\n" \
- "-----END ED25519 CERT-----\n" \
- "revision-counter %s\n" \
- "encrypted\n" \
- "-----BEGIN %s-----\n" \
- "UNICORN\n" \
- "-----END MESSAGE-----\n" \
- "signature m20WJH5agqvwhq7QeuEZ1mYyPWQDO+eJOZUjLhAiKu8DbL17DsDfJE6kXbWy" \
- "HimbNj2we0enV3cCOOAsmPOaAw\n"
- /* Invalid version. */
- {
- char *plaintext;
- tor_asprintf(&plaintext, template, bad_value, "180", "42", "MESSAGE");
- ret = hs_desc_decode_plaintext(plaintext, &desc_plaintext);
- tor_free(plaintext);
- tt_int_op(ret, OP_EQ, -1);
- }
- /* Missing fields. */
- {
- const char *plaintext = "hs-descriptor 3\n";
- ret = hs_desc_decode_plaintext(plaintext, &desc_plaintext);
- tt_int_op(ret, OP_EQ, -1);
- }
- /* Max length. */
- {
- size_t big = 64000;
- /* Must always be bigger than HS_DESC_MAX_LEN. */
- tt_int_op(HS_DESC_MAX_LEN, OP_LT, big);
- char *plaintext = tor_malloc_zero(big);
- memset(plaintext, 'a', big);
- plaintext[big - 1] = '\0';
- ret = hs_desc_decode_plaintext(plaintext, &desc_plaintext);
- tor_free(plaintext);
- tt_int_op(ret, OP_EQ, -1);
- }
- /* Bad lifetime value. */
- {
- char *plaintext;
- tor_asprintf(&plaintext, template, "3", bad_value, "42", "MESSAGE");
- ret = hs_desc_decode_plaintext(plaintext, &desc_plaintext);
- tor_free(plaintext);
- tt_int_op(ret, OP_EQ, -1);
- }
- /* Huge lifetime value. */
- {
- char *plaintext;
- tor_asprintf(&plaintext, template, "3", "7181615", "42", "MESSAGE");
- ret = hs_desc_decode_plaintext(plaintext, &desc_plaintext);
- tor_free(plaintext);
- tt_int_op(ret, OP_EQ, -1);
- }
- /* Invalid encrypted section. */
- {
- char *plaintext;
- tor_asprintf(&plaintext, template, "3", "180", "42", bad_value);
- ret = hs_desc_decode_plaintext(plaintext, &desc_plaintext);
- tor_free(plaintext);
- tt_int_op(ret, OP_EQ, -1);
- }
- /* Invalid revision counter. */
- {
- char *plaintext;
- tor_asprintf(&plaintext, template, "3", "180", bad_value, "MESSAGE");
- ret = hs_desc_decode_plaintext(plaintext, &desc_plaintext);
- tor_free(plaintext);
- tt_int_op(ret, OP_EQ, -1);
- }
- done:
- ;
- }
- static void
- test_validate_cert(void *arg)
- {
- int ret;
- time_t now = time(NULL);
- ed25519_keypair_t kp;
- tor_cert_t *cert = NULL;
- (void) arg;
- ret = ed25519_keypair_generate(&kp, 0);
- tt_int_op(ret, OP_EQ, 0);
- /* Cert of type CERT_TYPE_AUTH_HS_IP_KEY. */
- cert = tor_cert_create(&kp, CERT_TYPE_AUTH_HS_IP_KEY,
- &kp.pubkey, now, 3600,
- CERT_FLAG_INCLUDE_SIGNING_KEY);
- tt_assert(cert);
- /* Test with empty certificate. */
- ret = cert_is_valid(NULL, CERT_TYPE_AUTH_HS_IP_KEY, "unicorn");
- tt_int_op(ret, OP_EQ, 0);
- /* Test with a bad type. */
- ret = cert_is_valid(cert, CERT_TYPE_SIGNING_HS_DESC, "unicorn");
- tt_int_op(ret, OP_EQ, 0);
- /* Normal validation. */
- ret = cert_is_valid(cert, CERT_TYPE_AUTH_HS_IP_KEY, "unicorn");
- tt_int_op(ret, OP_EQ, 1);
- /* Break signing key so signature verification will fails. */
- memset(&cert->signing_key, 0, sizeof(cert->signing_key));
- ret = cert_is_valid(cert, CERT_TYPE_AUTH_HS_IP_KEY, "unicorn");
- tt_int_op(ret, OP_EQ, 0);
- tor_cert_free(cert);
- /* Try a cert without including the signing key. */
- cert = tor_cert_create(&kp, CERT_TYPE_AUTH_HS_IP_KEY, &kp.pubkey, now,
- 3600, 0);
- tt_assert(cert);
- /* Test with a bad type. */
- ret = cert_is_valid(cert, CERT_TYPE_AUTH_HS_IP_KEY, "unicorn");
- tt_int_op(ret, OP_EQ, 0);
- done:
- tor_cert_free(cert);
- }
- static void
- test_desc_signature(void *arg)
- {
- int ret;
- char *data = NULL, *desc = NULL;
- char sig_b64[ED25519_SIG_BASE64_LEN + 1];
- ed25519_keypair_t kp;
- ed25519_signature_t sig;
- (void) arg;
- ed25519_keypair_generate(&kp, 0);
- /* Setup a phoony descriptor but with a valid signature token that is the
- * signature is verifiable. */
- tor_asprintf(&data, "This is a signed descriptor\n");
- ret = ed25519_sign_prefixed(&sig, (const uint8_t *) data, strlen(data),
- "Tor onion service descriptor sig v3", &kp);
- tt_int_op(ret, OP_EQ, 0);
- ret = ed25519_signature_to_base64(sig_b64, &sig);
- tt_int_op(ret, OP_EQ, 0);
- /* Build the descriptor that should be valid. */
- tor_asprintf(&desc, "%ssignature %s\n", data, sig_b64);
- ret = desc_sig_is_valid(sig_b64, &kp.pubkey, desc, strlen(desc));
- tt_int_op(ret, OP_EQ, 1);
- /* Junk signature. */
- ret = desc_sig_is_valid("JUNK", &kp.pubkey, desc, strlen(desc));
- tt_int_op(ret, OP_EQ, 0);
- done:
- tor_free(desc);
- tor_free(data);
- }
- /* bad desc auth type */
- static const char bad_superencrypted_text1[] = "desc-auth-type scoobysnack\n"
- "desc-auth-ephemeral-key A/O8DVtnUheb3r1JqoB8uJB7wxXL1XJX3eny4yB+eFA=\n"
- "auth-client oiNrQB8WwKo S5D02W7vKgiWIMygrBl8RQ FB//SfOBmLEx1kViEWWL1g\n"
- "encrypted\n"
- "-----BEGIN MESSAGE-----\n"
- "YmVpbmcgb24gbW91bnRhaW5zLCB0aGlua2luZyBhYm91dCBjb21wdXRlcnMsIGlzIG5vdC"
- "BiYWQgYXQgYWxs\n"
- "-----END MESSAGE-----\n";
- /* bad ephemeral key */
- static const char bad_superencrypted_text2[] = "desc-auth-type x25519\n"
- "desc-auth-ephemeral-key differentalphabet\n"
- "auth-client oiNrQB8WwKo S5D02W7vKgiWIMygrBl8RQ FB//SfOBmLEx1kViEWWL1g\n"
- "encrypted\n"
- "-----BEGIN MESSAGE-----\n"
- "YmVpbmcgb24gbW91bnRhaW5zLCB0aGlua2luZyBhYm91dCBjb21wdXRlcnMsIGlzIG5vdC"
- "BiYWQgYXQgYWxs\n"
- "-----END MESSAGE-----\n";
- /* bad encrypted msg */
- static const char bad_superencrypted_text3[] = "desc-auth-type x25519\n"
- "desc-auth-ephemeral-key A/O8DVtnUheb3r1JqoB8uJB7wxXL1XJX3eny4yB+eFA=\n"
- "auth-client oiNrQB8WwKo S5D02W7vKgiWIMygrBl8RQ FB//SfOBmLEx1kViEWWL1g\n"
- "encrypted\n"
- "-----BEGIN MESSAGE-----\n"
- "SO SMALL NOT GOOD\n"
- "-----END MESSAGE-----\n";
- static const char correct_superencrypted_text[] = "desc-auth-type x25519\n"
- "desc-auth-ephemeral-key A/O8DVtnUheb3r1JqoB8uJB7wxXL1XJX3eny4yB+eFA=\n"
- "auth-client oiNrQB8WwKo S5D02W7vKgiWIMygrBl8RQ FB//SfOBmLEx1kViEWWL1g\n"
- "auth-client Od09Qu636Qo /PKLzqewAdS/+0+vZC+MvQ dpw4NFo13zDnuPz45rxrOg\n"
- "auth-client JRr840iGYN0 8s8cxYqF7Lx23+NducC4Qg zAafl4wPLURkuEjJreZq1g\n"
- "encrypted\n"
- "-----BEGIN MESSAGE-----\n"
- "YmVpbmcgb24gbW91bnRhaW5zLCB0aGlua2luZyBhYm91dCBjb21wdXRlcnMsIGlzIG5vdC"
- "BiYWQgYXQgYWxs\n"
- "-----END MESSAGE-----\n";
- static const char correct_encrypted_plaintext[] = "being on mountains, "
- "thinking about computers, is not bad at all";
- static void
- test_parse_hs_desc_superencrypted(void *arg)
- {
- (void) arg;
- size_t retval;
- uint8_t *encrypted_out = NULL;
- {
- setup_full_capture_of_logs(LOG_WARN);
- retval = decode_superencrypted(bad_superencrypted_text1,
- strlen(bad_superencrypted_text1),
- &encrypted_out);
- tt_u64_op(retval, OP_EQ, 0);
- tt_ptr_op(encrypted_out, OP_EQ, NULL);
- expect_log_msg_containing("Unrecognized desc auth type");
- teardown_capture_of_logs();
- }
- {
- setup_full_capture_of_logs(LOG_WARN);
- retval = decode_superencrypted(bad_superencrypted_text2,
- strlen(bad_superencrypted_text2),
- &encrypted_out);
- tt_u64_op(retval, OP_EQ, 0);
- tt_ptr_op(encrypted_out, OP_EQ, NULL);
- expect_log_msg_containing("Bogus desc auth key in HS desc");
- teardown_capture_of_logs();
- }
- {
- setup_full_capture_of_logs(LOG_WARN);
- retval = decode_superencrypted(bad_superencrypted_text3,
- strlen(bad_superencrypted_text3),
- &encrypted_out);
- tt_u64_op(retval, OP_EQ, 0);
- tt_ptr_op(encrypted_out, OP_EQ, NULL);
- expect_log_msg_containing("Length of descriptor\'s encrypted data "
- "is too small.");
- teardown_capture_of_logs();
- }
- /* Now finally the good one */
- retval = decode_superencrypted(correct_superencrypted_text,
- strlen(correct_superencrypted_text),
- &encrypted_out);
- tt_u64_op(retval, OP_EQ, strlen(correct_encrypted_plaintext));
- tt_mem_op(encrypted_out, OP_EQ, correct_encrypted_plaintext,
- strlen(correct_encrypted_plaintext));
- done:
- tor_free(encrypted_out);
- }
- struct testcase_t hs_descriptor[] = {
- /* Encoding tests. */
- { "cert_encoding", test_cert_encoding, TT_FORK,
- NULL, NULL },
- { "link_specifier", test_link_specifier, TT_FORK,
- NULL, NULL },
- { "encode_descriptor", test_encode_descriptor, TT_FORK,
- NULL, NULL },
- { "descriptor_padding", test_descriptor_padding, TT_FORK,
- NULL, NULL },
- /* Decoding tests. */
- { "decode_descriptor", test_decode_descriptor, TT_FORK,
- NULL, NULL },
- { "encrypted_data_len", test_encrypted_data_len, TT_FORK,
- NULL, NULL },
- { "decode_invalid_intro_point", test_decode_invalid_intro_point, TT_FORK,
- NULL, NULL },
- { "decode_plaintext", test_decode_plaintext, TT_FORK,
- NULL, NULL },
- { "decode_bad_signature", test_decode_bad_signature, TT_FORK,
- NULL, NULL },
- /* Misc. */
- { "version", test_supported_version, TT_FORK,
- NULL, NULL },
- { "validate_cert", test_validate_cert, TT_FORK,
- NULL, NULL },
- { "desc_signature", test_desc_signature, TT_FORK,
- NULL, NULL },
- { "parse_hs_desc_superencrypted", test_parse_hs_desc_superencrypted,
- TT_FORK, NULL, NULL },
- END_OF_TESTCASES
- };
|