hs_config.c 23 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660
  1. /* Copyright (c) 2017-2018, The Tor Project, Inc. */
  2. /* See LICENSE for licensing information */
  3. /**
  4. * \file hs_config.c
  5. * \brief Implement hidden service configuration subsystem.
  6. *
  7. * \details
  8. *
  9. * This file has basically one main entry point: hs_config_service_all(). It
  10. * takes the torrc options and configure hidden service from it. In validate
  11. * mode, nothing is added to the global service list or keys are not generated
  12. * nor loaded.
  13. *
  14. * A service is configured in two steps. It is first created using the tor
  15. * options and then put in a staging list. It will stay there until
  16. * hs_service_load_all_keys() is called. That function is responsible to
  17. * load/generate the keys for the service in the staging list and if
  18. * successful, transfert the service to the main global service list where
  19. * at that point it is ready to be used.
  20. *
  21. * Configuration functions are per-version and there is a main generic one for
  22. * every option that is common to all version (config_generic_service).
  23. **/
  24. #define HS_CONFIG_PRIVATE
  25. #include "feature/hs/hs_common.h"
  26. #include "feature/hs/hs_config.h"
  27. #include "feature/hs/hs_client.h"
  28. #include "feature/hs/hs_service.h"
  29. #include "feature/rend/rendclient.h"
  30. #include "feature/rend/rendservice.h"
  31. #include "lib/encoding/confline.h"
  32. #include "app/config/or_options_st.h"
  33. /* Using the given list of services, stage them into our global state. Every
  34. * service version are handled. This function can remove entries in the given
  35. * service_list.
  36. *
  37. * Staging a service means that we take all services in service_list and we
  38. * put them in the staging list (global) which acts as a temporary list that
  39. * is used by the service loading key process. In other words, staging a
  40. * service puts it in a list to be considered when loading the keys and then
  41. * moved to the main global list. */
  42. static void
  43. stage_services(smartlist_t *service_list)
  44. {
  45. tor_assert(service_list);
  46. /* This is v2 specific. Trigger service pruning which will make sure the
  47. * just configured services end up in the main global list. It should only
  48. * be done in non validation mode because v2 subsystem handles service
  49. * object differently. */
  50. rend_service_prune_list();
  51. /* Cleanup v2 service from the list, we don't need those object anymore
  52. * because we validated them all against the others and we want to stage
  53. * only >= v3 service. And remember, v2 has a different object type which is
  54. * shadow copied from an hs_service_t type. */
  55. SMARTLIST_FOREACH_BEGIN(service_list, hs_service_t *, s) {
  56. if (s->config.version == HS_VERSION_TWO) {
  57. SMARTLIST_DEL_CURRENT(service_list, s);
  58. hs_service_free(s);
  59. }
  60. } SMARTLIST_FOREACH_END(s);
  61. /* This is >= v3 specific. Using the newly configured service list, stage
  62. * them into our global state. Every object ownership is lost after. */
  63. hs_service_stage_services(service_list);
  64. }
  65. /* Validate the given service against all service in the given list. If the
  66. * service is ephemeral, this function ignores it. Services with the same
  67. * directory path aren't allowed and will return an error. If a duplicate is
  68. * found, 1 is returned else 0 if none found. */
  69. static int
  70. service_is_duplicate_in_list(const smartlist_t *service_list,
  71. const hs_service_t *service)
  72. {
  73. int ret = 0;
  74. tor_assert(service_list);
  75. tor_assert(service);
  76. /* Ephemeral service don't have a directory configured so no need to check
  77. * for a service in the list having the same path. */
  78. if (service->config.is_ephemeral) {
  79. goto end;
  80. }
  81. /* XXX: Validate if we have any service that has the given service dir path.
  82. * This has two problems:
  83. *
  84. * a) It's O(n^2), but the same comment from the bottom of
  85. * rend_config_services() should apply.
  86. *
  87. * b) We only compare directory paths as strings, so we can't
  88. * detect two distinct paths that specify the same directory
  89. * (which can arise from symlinks, case-insensitivity, bind
  90. * mounts, etc.).
  91. *
  92. * It also can't detect that two separate Tor instances are trying
  93. * to use the same HiddenServiceDir; for that, we would need a
  94. * lock file. But this is enough to detect a simple mistake that
  95. * at least one person has actually made. */
  96. SMARTLIST_FOREACH_BEGIN(service_list, const hs_service_t *, s) {
  97. if (!strcmp(s->config.directory_path, service->config.directory_path)) {
  98. log_warn(LD_REND, "Another hidden service is already configured "
  99. "for directory %s",
  100. escaped(service->config.directory_path));
  101. ret = 1;
  102. goto end;
  103. }
  104. } SMARTLIST_FOREACH_END(s);
  105. end:
  106. return ret;
  107. }
  108. /* Helper function: Given an configuration option name, its value, a minimum
  109. * min and a maxium max, parse the value as a uint64_t. On success, ok is set
  110. * to 1 and ret is the parsed value. On error, ok is set to 0 and ret must be
  111. * ignored. This function logs both on error and success. */
  112. static uint64_t
  113. helper_parse_uint64(const char *opt, const char *value, uint64_t min,
  114. uint64_t max, int *ok)
  115. {
  116. uint64_t ret = 0;
  117. tor_assert(opt);
  118. tor_assert(value);
  119. tor_assert(ok);
  120. *ok = 0;
  121. ret = tor_parse_uint64(value, 10, min, max, ok, NULL);
  122. if (!*ok) {
  123. log_warn(LD_CONFIG, "%s must be between %" PRIu64 " and %"PRIu64
  124. ", not %s.",
  125. opt, min, max, value);
  126. goto err;
  127. }
  128. log_info(LD_CONFIG, "%s was parsed to %" PRIu64, opt, ret);
  129. err:
  130. return ret;
  131. }
  132. /* Return the service version by trying to learn it from the key on disk if
  133. * any. If nothing is found, the current service configured version is
  134. * returned. */
  135. static int
  136. config_learn_service_version(hs_service_t *service)
  137. {
  138. int version;
  139. tor_assert(service);
  140. version = hs_service_get_version_from_key(service);
  141. if (version < 0) {
  142. version = service->config.version;
  143. }
  144. return version;
  145. }
  146. /* Return true iff the given options starting at line_ for a hidden service
  147. * contains at least one invalid option. Each hidden service option don't
  148. * apply to all versions so this function can find out. The line_ MUST start
  149. * right after the HiddenServiceDir line of this service.
  150. *
  151. * This is mainly for usability so we can inform the user of any invalid
  152. * option for the hidden service version instead of silently ignoring. */
  153. static int
  154. config_has_invalid_options(const config_line_t *line_,
  155. const hs_service_t *service)
  156. {
  157. int ret = 0;
  158. const char **optlist;
  159. const config_line_t *line;
  160. tor_assert(service);
  161. tor_assert(service->config.version <= HS_VERSION_MAX);
  162. /* List of options that a v3 service doesn't support thus must exclude from
  163. * its configuration. */
  164. const char *opts_exclude_v3[] = {
  165. "HiddenServiceAuthorizeClient",
  166. NULL /* End marker. */
  167. };
  168. const char *opts_exclude_v2[] = {
  169. "HiddenServiceExportCircuitID",
  170. NULL /* End marker. */
  171. };
  172. /* Defining the size explicitly allows us to take advantage of the compiler
  173. * which warns us if we ever bump the max version but forget to grow this
  174. * array. The plus one is because we have a version 0 :). */
  175. struct {
  176. const char **list;
  177. } exclude_lists[HS_VERSION_MAX + 1] = {
  178. { NULL }, /* v0. */
  179. { NULL }, /* v1. */
  180. { opts_exclude_v2 }, /* v2 */
  181. { opts_exclude_v3 }, /* v3. */
  182. };
  183. optlist = exclude_lists[service->config.version].list;
  184. if (optlist == NULL) {
  185. /* No exclude options to look at for this version. */
  186. goto end;
  187. }
  188. for (int i = 0; optlist[i]; i++) {
  189. const char *opt = optlist[i];
  190. for (line = line_; line; line = line->next) {
  191. if (!strcasecmp(line->key, "HiddenServiceDir")) {
  192. /* We just hit the next hidden service, stop right now. */
  193. goto end;
  194. }
  195. if (!strcasecmp(line->key, opt)) {
  196. log_warn(LD_CONFIG, "Hidden service option %s is incompatible with "
  197. "version %" PRIu32 " of service in %s",
  198. opt, service->config.version,
  199. service->config.directory_path);
  200. ret = 1;
  201. /* Continue the loop so we can find all possible options. */
  202. continue;
  203. }
  204. }
  205. }
  206. end:
  207. return ret;
  208. }
  209. /* Validate service configuration. This is used when loading the configuration
  210. * and once we've setup a service object, it's config object is passed to this
  211. * function for further validation. This does not validate service key
  212. * material. Return 0 if valid else -1 if invalid. */
  213. static int
  214. config_validate_service(const hs_service_config_t *config)
  215. {
  216. tor_assert(config);
  217. /* Amount of ports validation. */
  218. if (!config->ports || smartlist_len(config->ports) == 0) {
  219. log_warn(LD_CONFIG, "Hidden service (%s) with no ports configured.",
  220. escaped(config->directory_path));
  221. goto invalid;
  222. }
  223. /* Valid. */
  224. return 0;
  225. invalid:
  226. return -1;
  227. }
  228. /* Configuration funcion for a version 3 service. The line_ must be pointing
  229. * to the directive directly after a HiddenServiceDir. That way, when hitting
  230. * the next HiddenServiceDir line or reaching the end of the list of lines, we
  231. * know that we have to stop looking for more options. The given service
  232. * object must be already allocated and passed through
  233. * config_generic_service() prior to calling this function.
  234. *
  235. * Return 0 on success else a negative value. */
  236. static int
  237. config_service_v3(const config_line_t *line_,
  238. hs_service_config_t *config)
  239. {
  240. int have_num_ip = 0;
  241. bool export_circuit_id = false; /* just to detect duplicate options */
  242. const char *dup_opt_seen = NULL;
  243. const config_line_t *line;
  244. tor_assert(config);
  245. for (line = line_; line; line = line->next) {
  246. int ok = 0;
  247. if (!strcasecmp(line->key, "HiddenServiceDir")) {
  248. /* We just hit the next hidden service, stop right now. */
  249. break;
  250. }
  251. /* Number of introduction points. */
  252. if (!strcasecmp(line->key, "HiddenServiceNumIntroductionPoints")) {
  253. config->num_intro_points =
  254. (unsigned int) helper_parse_uint64(line->key, line->value,
  255. NUM_INTRO_POINTS_DEFAULT,
  256. HS_CONFIG_V3_MAX_INTRO_POINTS,
  257. &ok);
  258. if (!ok || have_num_ip) {
  259. if (have_num_ip)
  260. dup_opt_seen = line->key;
  261. goto err;
  262. }
  263. have_num_ip = 1;
  264. continue;
  265. }
  266. if (!strcasecmp(line->key, "HiddenServiceExportCircuitID")) {
  267. config->export_circuit_id =
  268. (unsigned int) helper_parse_uint64(line->key, line->value, 0, 1, &ok);
  269. if (!ok || export_circuit_id) {
  270. if (export_circuit_id) {
  271. dup_opt_seen = line->key;
  272. }
  273. goto err;
  274. }
  275. export_circuit_id = true;
  276. continue;
  277. }
  278. }
  279. /* We do not load the key material for the service at this stage. This is
  280. * done later once tor can confirm that it is in a running state. */
  281. /* We are about to return a fully configured service so do one last pass of
  282. * validation at it. */
  283. if (config_validate_service(config) < 0) {
  284. goto err;
  285. }
  286. return 0;
  287. err:
  288. if (dup_opt_seen) {
  289. log_warn(LD_CONFIG, "Duplicate directive %s.", dup_opt_seen);
  290. }
  291. return -1;
  292. }
  293. /* Configure a service using the given options in line_ and options. This is
  294. * called for any service regardless of its version which means that all
  295. * directives in this function are generic to any service version. This
  296. * function will also check the validity of the service directory path.
  297. *
  298. * The line_ must be pointing to the directive directly after a
  299. * HiddenServiceDir. That way, when hitting the next HiddenServiceDir line or
  300. * reaching the end of the list of lines, we know that we have to stop looking
  301. * for more options.
  302. *
  303. * Return 0 on success else -1. */
  304. static int
  305. config_generic_service(const config_line_t *line_,
  306. const or_options_t *options,
  307. hs_service_t *service)
  308. {
  309. int dir_seen = 0;
  310. const config_line_t *line;
  311. hs_service_config_t *config;
  312. /* If this is set, we've seen a duplicate of this option. Keep the string
  313. * so we can log the directive. */
  314. const char *dup_opt_seen = NULL;
  315. /* These variables will tell us if we ever have duplicate. */
  316. int have_version = 0, have_allow_unknown_ports = 0;
  317. int have_dir_group_read = 0, have_max_streams = 0;
  318. int have_max_streams_close = 0;
  319. tor_assert(line_);
  320. tor_assert(options);
  321. tor_assert(service);
  322. /* Makes thing easier. */
  323. config = &service->config;
  324. /* The first line starts with HiddenServiceDir so we consider what's next is
  325. * the configuration of the service. */
  326. for (line = line_; line ; line = line->next) {
  327. int ok = 0;
  328. /* This indicate that we have a new service to configure. */
  329. if (!strcasecmp(line->key, "HiddenServiceDir")) {
  330. /* This function only configures one service at a time so if we've
  331. * already seen one, stop right now. */
  332. if (dir_seen) {
  333. break;
  334. }
  335. /* Ok, we've seen one and we are about to configure it. */
  336. dir_seen = 1;
  337. config->directory_path = tor_strdup(line->value);
  338. log_info(LD_CONFIG, "HiddenServiceDir=%s. Configuring...",
  339. escaped(config->directory_path));
  340. continue;
  341. }
  342. if (BUG(!dir_seen)) {
  343. goto err;
  344. }
  345. /* Version of the service. */
  346. if (!strcasecmp(line->key, "HiddenServiceVersion")) {
  347. service->config.version =
  348. (uint32_t) helper_parse_uint64(line->key, line->value, HS_VERSION_MIN,
  349. HS_VERSION_MAX, &ok);
  350. if (!ok || have_version) {
  351. if (have_version)
  352. dup_opt_seen = line->key;
  353. goto err;
  354. }
  355. have_version = 1;
  356. continue;
  357. }
  358. /* Virtual port. */
  359. if (!strcasecmp(line->key, "HiddenServicePort")) {
  360. char *err_msg = NULL;
  361. /* XXX: Can we rename this? */
  362. rend_service_port_config_t *portcfg =
  363. rend_service_parse_port_config(line->value, " ", &err_msg);
  364. if (!portcfg) {
  365. if (err_msg) {
  366. log_warn(LD_CONFIG, "%s", err_msg);
  367. }
  368. tor_free(err_msg);
  369. goto err;
  370. }
  371. tor_assert(!err_msg);
  372. smartlist_add(config->ports, portcfg);
  373. log_info(LD_CONFIG, "HiddenServicePort=%s for %s",
  374. line->value, escaped(config->directory_path));
  375. continue;
  376. }
  377. /* Do we allow unknown ports. */
  378. if (!strcasecmp(line->key, "HiddenServiceAllowUnknownPorts")) {
  379. config->allow_unknown_ports =
  380. (unsigned int) helper_parse_uint64(line->key, line->value, 0, 1, &ok);
  381. if (!ok || have_allow_unknown_ports) {
  382. if (have_allow_unknown_ports)
  383. dup_opt_seen = line->key;
  384. goto err;
  385. }
  386. have_allow_unknown_ports = 1;
  387. continue;
  388. }
  389. /* Directory group readable. */
  390. if (!strcasecmp(line->key, "HiddenServiceDirGroupReadable")) {
  391. config->dir_group_readable =
  392. (unsigned int) helper_parse_uint64(line->key, line->value, 0, 1, &ok);
  393. if (!ok || have_dir_group_read) {
  394. if (have_dir_group_read)
  395. dup_opt_seen = line->key;
  396. goto err;
  397. }
  398. have_dir_group_read = 1;
  399. continue;
  400. }
  401. /* Maximum streams per circuit. */
  402. if (!strcasecmp(line->key, "HiddenServiceMaxStreams")) {
  403. config->max_streams_per_rdv_circuit =
  404. helper_parse_uint64(line->key, line->value, 0,
  405. HS_CONFIG_MAX_STREAMS_PER_RDV_CIRCUIT, &ok);
  406. if (!ok || have_max_streams) {
  407. if (have_max_streams)
  408. dup_opt_seen = line->key;
  409. goto err;
  410. }
  411. have_max_streams = 1;
  412. continue;
  413. }
  414. /* Maximum amount of streams before we close the circuit. */
  415. if (!strcasecmp(line->key, "HiddenServiceMaxStreamsCloseCircuit")) {
  416. config->max_streams_close_circuit =
  417. (unsigned int) helper_parse_uint64(line->key, line->value, 0, 1, &ok);
  418. if (!ok || have_max_streams_close) {
  419. if (have_max_streams_close)
  420. dup_opt_seen = line->key;
  421. goto err;
  422. }
  423. have_max_streams_close = 1;
  424. continue;
  425. }
  426. }
  427. /* Check if we are configured in non anonymous mode meaning every service
  428. * becomes a single onion service. */
  429. if (rend_service_non_anonymous_mode_enabled(options)) {
  430. config->is_single_onion = 1;
  431. /* We will add support for IPv6-only v3 single onion services in a future
  432. * Tor version. This won't catch "ReachableAddresses reject *4", but that
  433. * option doesn't work anyway. */
  434. if (options->ClientUseIPv4 == 0 && config->version == HS_VERSION_THREE) {
  435. log_warn(LD_CONFIG, "IPv6-only v3 single onion services are not "
  436. "supported. Set HiddenServiceSingleHopMode 0 and "
  437. "HiddenServiceNonAnonymousMode 0, or set ClientUseIPv4 1.");
  438. goto err;
  439. }
  440. }
  441. /* Success */
  442. return 0;
  443. err:
  444. if (dup_opt_seen) {
  445. log_warn(LD_CONFIG, "Duplicate directive %s.", dup_opt_seen);
  446. }
  447. return -1;
  448. }
  449. /* Configure a service using the given line and options. This function will
  450. * call the corresponding configuration function for a specific service
  451. * version and validate the service against the other ones. On success, add
  452. * the service to the given list and return 0. On error, nothing is added to
  453. * the list and a negative value is returned. */
  454. static int
  455. config_service(const config_line_t *line, const or_options_t *options,
  456. smartlist_t *service_list)
  457. {
  458. int ret;
  459. hs_service_t *service = NULL;
  460. tor_assert(line);
  461. tor_assert(options);
  462. tor_assert(service_list);
  463. /* We have a new hidden service. */
  464. service = hs_service_new(options);
  465. /* We'll configure that service as a generic one and then pass it to a
  466. * specific function according to the configured version number. */
  467. if (config_generic_service(line, options, service) < 0) {
  468. goto err;
  469. }
  470. tor_assert(service->config.version <= HS_VERSION_MAX);
  471. /* Before we configure the service on a per-version basis, we'll make
  472. * sure that this set of options for a service are valid that is for
  473. * instance an option only for v2 is not used for v3. */
  474. if (config_has_invalid_options(line->next, service)) {
  475. goto err;
  476. }
  477. /* Check permission on service directory that was just parsed. And this must
  478. * be done regardless of the service version. Do not ask for the directory
  479. * to be created, this is done when the keys are loaded because we could be
  480. * in validation mode right now. */
  481. if (hs_check_service_private_dir(options->User,
  482. service->config.directory_path,
  483. service->config.dir_group_readable,
  484. 0) < 0) {
  485. goto err;
  486. }
  487. /* We'll try to learn the service version here by loading the key(s) if
  488. * present. Depending on the key format, we can figure out the service
  489. * version. If we can't find a key, the configuration version will be used
  490. * which has been set previously. */
  491. service->config.version = config_learn_service_version(service);
  492. /* Different functions are in charge of specific options for a version. We
  493. * start just after the service directory line so once we hit another
  494. * directory line, the function knows that it has to stop parsing. */
  495. switch (service->config.version) {
  496. case HS_VERSION_TWO:
  497. ret = rend_config_service(line->next, options, &service->config);
  498. break;
  499. case HS_VERSION_THREE:
  500. ret = config_service_v3(line->next, &service->config);
  501. break;
  502. default:
  503. /* We do validate before if we support the parsed version. */
  504. tor_assert_nonfatal_unreached();
  505. goto err;
  506. }
  507. if (ret < 0) {
  508. goto err;
  509. }
  510. /* We'll check if this service can be kept depending on the others
  511. * configured previously. */
  512. if (service_is_duplicate_in_list(service_list, service)) {
  513. goto err;
  514. }
  515. /* Passes, add it to the given list. */
  516. smartlist_add(service_list, service);
  517. return 0;
  518. err:
  519. hs_service_free(service);
  520. return -1;
  521. }
  522. /* From a set of <b>options</b>, setup every hidden service found. Return 0 on
  523. * success or -1 on failure. If <b>validate_only</b> is set, parse, warn and
  524. * return as normal, but don't actually change the configured services. */
  525. int
  526. hs_config_service_all(const or_options_t *options, int validate_only)
  527. {
  528. int dir_option_seen = 0, ret = -1;
  529. const config_line_t *line;
  530. smartlist_t *new_service_list = NULL;
  531. tor_assert(options);
  532. /* Newly configured service are put in that list which is then used for
  533. * validation and staging for >= v3. */
  534. new_service_list = smartlist_new();
  535. for (line = options->RendConfigLines; line; line = line->next) {
  536. /* Ignore all directives that aren't the start of a service. */
  537. if (strcasecmp(line->key, "HiddenServiceDir")) {
  538. if (!dir_option_seen) {
  539. log_warn(LD_CONFIG, "%s with no preceding HiddenServiceDir directive",
  540. line->key);
  541. goto err;
  542. }
  543. continue;
  544. }
  545. /* Flag that we've seen a directory directive and we'll use it to make
  546. * sure that the torrc options ordering is actually valid. */
  547. dir_option_seen = 1;
  548. /* Try to configure this service now. On success, it will be added to the
  549. * list and validated against the service in that same list. */
  550. if (config_service(line, options, new_service_list) < 0) {
  551. goto err;
  552. }
  553. }
  554. /* In non validation mode, we'll stage those services we just successfully
  555. * configured. Service ownership is transferred from the list to the global
  556. * state. If any service is invalid, it will be removed from the list and
  557. * freed. All versions are handled in that function. */
  558. if (!validate_only) {
  559. stage_services(new_service_list);
  560. } else {
  561. /* We've just validated that we were able to build a clean working list of
  562. * services. We don't need those objects anymore. */
  563. SMARTLIST_FOREACH(new_service_list, hs_service_t *, s,
  564. hs_service_free(s));
  565. /* For the v2 subsystem, the configuration function adds the service
  566. * object to the staging list and it is transferred in the main list
  567. * through the prunning process. In validation mode, we thus have to purge
  568. * the staging list so it's not kept in memory as valid service. */
  569. rend_service_free_staging_list();
  570. }
  571. /* Success. Note that the service list has no ownership of its content. */
  572. ret = 0;
  573. goto end;
  574. err:
  575. SMARTLIST_FOREACH(new_service_list, hs_service_t *, s, hs_service_free(s));
  576. end:
  577. smartlist_free(new_service_list);
  578. /* Tor main should call the free all function on error. */
  579. return ret;
  580. }
  581. /* From a set of <b>options</b>, setup every client authorization found.
  582. * Return 0 on success or -1 on failure. If <b>validate_only</b> is set,
  583. * parse, warn and return as normal, but don't actually change the
  584. * configured state. */
  585. int
  586. hs_config_client_auth_all(const or_options_t *options, int validate_only)
  587. {
  588. int ret = -1;
  589. /* Configure v2 authorization. */
  590. if (rend_parse_service_authorization(options, validate_only) < 0) {
  591. goto done;
  592. }
  593. /* Configure v3 authorization. */
  594. if (hs_config_client_authorization(options, validate_only) < 0) {
  595. goto done;
  596. }
  597. /* Success. */
  598. ret = 0;
  599. done:
  600. return ret;
  601. }