scheduler.c 22 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653
  1. /* * Copyright (c) 2013-2017, The Tor Project, Inc. */
  2. /* See LICENSE for licensing information */
  3. #include "or.h"
  4. #include "config.h"
  5. #include "compat_libevent.h"
  6. #define SCHEDULER_PRIVATE_
  7. #define SCHEDULER_KIST_PRIVATE
  8. #include "scheduler.h"
  9. #include <event2/event.h>
  10. /**
  11. * \file scheduler.c
  12. * \brief Channel scheduling system: decides which channels should send and
  13. * receive when.
  14. *
  15. * This module is the global/common parts of the scheduling system. This system
  16. * is what decides what channels get to send cells on their circuits and when.
  17. *
  18. * Terms:
  19. * - "Scheduling system": the collection of scheduler*.{h,c} files and their
  20. * aggregate behavior.
  21. * - "Scheduler implementation": a scheduler_t. The scheduling system has one
  22. * active scheduling implementation at a time.
  23. *
  24. * In this file you will find state that any scheduler implementation can have
  25. * access to as well as the functions the rest of Tor uses to interact with the
  26. * scheduling system.
  27. *
  28. * The earliest versions of Tor approximated a kind of round-robin system
  29. * among active connections, but only approximated it. It would only consider
  30. * one connection (roughly equal to a channel in today's terms) at a time, and
  31. * thus could only prioritize circuits against others on the same connection.
  32. *
  33. * Then in response to the KIST paper[0], Tor implemented a global
  34. * circuit scheduler. It was supposed to prioritize circuits across many
  35. * channels, but wasn't effective. It is preserved in scheduler_vanilla.c.
  36. *
  37. * [0]: http://www.robgjansen.com/publications/kist-sec2014.pdf
  38. *
  39. * Then we actually got around to implementing KIST for real. We decided to
  40. * modularize the scheduler so new ones can be implemented. You can find KIST
  41. * in scheduler_kist.c.
  42. *
  43. * Channels have one of four scheduling states based on whether or not they
  44. * have cells to send and whether or not they are able to send.
  45. *
  46. * <ol>
  47. * <li>
  48. * Not open for writes, no cells to send.
  49. * <ul><li> Not much to do here, and the channel will have scheduler_state
  50. * == SCHED_CHAN_IDLE
  51. * <li> Transitions from:
  52. * <ul>
  53. * <li>Open for writes/has cells by simultaneously draining all circuit
  54. * queues and filling the output buffer.
  55. * </ul>
  56. * <li> Transitions to:
  57. * <ul>
  58. * <li> Not open for writes/has cells by arrival of cells on an attached
  59. * circuit (this would be driven from append_cell_to_circuit_queue())
  60. * <li> Open for writes/no cells by a channel type specific path;
  61. * driven from connection_or_flushed_some() for channel_tls_t.
  62. * </ul>
  63. * </ul>
  64. *
  65. * <li> Open for writes, no cells to send
  66. * <ul>
  67. * <li>Not much here either; this will be the state an idle but open
  68. * channel can be expected to settle in. It will have scheduler_state
  69. * == SCHED_CHAN_WAITING_FOR_CELLS
  70. * <li> Transitions from:
  71. * <ul>
  72. * <li>Not open for writes/no cells by flushing some of the output
  73. * buffer.
  74. * <li>Open for writes/has cells by the scheduler moving cells from
  75. * circuit queues to channel output queue, but not having enough
  76. * to fill the output queue.
  77. * </ul>
  78. * <li> Transitions to:
  79. * <ul>
  80. * <li>Open for writes/has cells by arrival of new cells on an attached
  81. * circuit, in append_cell_to_circuit_queue()
  82. * </ul>
  83. * </ul>
  84. *
  85. * <li>Not open for writes, cells to send
  86. * <ul>
  87. * <li>This is the state of a busy circuit limited by output bandwidth;
  88. * cells have piled up in the circuit queues waiting to be relayed.
  89. * The channel will have scheduler_state == SCHED_CHAN_WAITING_TO_WRITE.
  90. * <li> Transitions from:
  91. * <ul>
  92. * <li>Not open for writes/no cells by arrival of cells on an attached
  93. * circuit
  94. * <li>Open for writes/has cells by filling an output buffer without
  95. * draining all cells from attached circuits
  96. * </ul>
  97. * <li> Transitions to:
  98. * <ul>
  99. * <li>Opens for writes/has cells by draining some of the output buffer
  100. * via the connection_or_flushed_some() path (for channel_tls_t).
  101. * </ul>
  102. * </ul>
  103. *
  104. * <li>Open for writes, cells to send
  105. * <ul>
  106. * <li>This connection is ready to relay some cells and waiting for
  107. * the scheduler to choose it. The channel will have scheduler_state ==
  108. * SCHED_CHAN_PENDING.
  109. * <li>Transitions from:
  110. * <ul>
  111. * <li>Not open for writes/has cells by the connection_or_flushed_some()
  112. * path
  113. * <li>Open for writes/no cells by the append_cell_to_circuit_queue()
  114. * path
  115. * </ul>
  116. * <li> Transitions to:
  117. * <ul>
  118. * <li>Not open for writes/no cells by draining all circuit queues and
  119. * simultaneously filling the output buffer.
  120. * <li>Not open for writes/has cells by writing enough cells to fill the
  121. * output buffer
  122. * <li>Open for writes/no cells by draining all attached circuit queues
  123. * without also filling the output buffer
  124. * </ul>
  125. * </ul>
  126. * </ol>
  127. *
  128. * Other event-driven parts of the code move channels between these scheduling
  129. * states by calling scheduler functions. The scheduling system builds up a
  130. * list of channels in the SCHED_CHAN_PENDING state that the scheduler
  131. * implementation should then use when it runs. Scheduling implementations need
  132. * to properly update channel states during their scheduler_t->run() function
  133. * as that is the only opportunity for channels to move from SCHED_CHAN_PENDING
  134. * to any other state.
  135. *
  136. * The remainder of this file is a small amount of state that any scheduler
  137. * implementation should have access to, and the functions the rest of Tor uses
  138. * to interact with the scheduling system.
  139. */
  140. /*****************************************************************************
  141. * Scheduling system state
  142. *
  143. * State that can be accessed from any scheduler implementation (but not
  144. * outside the scheduling system)
  145. *****************************************************************************/
  146. /** DOCDOC */
  147. STATIC const scheduler_t *the_scheduler;
  148. /**
  149. * We keep a list of channels that are pending - i.e, have cells to write
  150. * and can accept them to send. The enum scheduler_state in channel_t
  151. * is reserved for our use.
  152. *
  153. * Priority queue of channels that can write and have cells (pending work)
  154. */
  155. STATIC smartlist_t *channels_pending = NULL;
  156. /**
  157. * This event runs the scheduler from its callback, and is manually
  158. * activated whenever a channel enters open for writes/cells to send.
  159. */
  160. STATIC struct event *run_sched_ev = NULL;
  161. /*****************************************************************************
  162. * Scheduling system static function definitions
  163. *
  164. * Functions that can only be accessed from this file.
  165. *****************************************************************************/
  166. /**
  167. * Scheduler event callback; this should get triggered once per event loop
  168. * if any scheduling work was created during the event loop.
  169. */
  170. static void
  171. scheduler_evt_callback(evutil_socket_t fd, short events, void *arg)
  172. {
  173. (void) fd;
  174. (void) events;
  175. (void) arg;
  176. log_debug(LD_SCHED, "Scheduler event callback called");
  177. /* Run the scheduler. This is a mandatory function. */
  178. /* We might as well assert on this. If this function doesn't exist, no cells
  179. * are getting scheduled. Things are very broken. scheduler_t says the run()
  180. * function is mandatory. */
  181. tor_assert(the_scheduler->run);
  182. the_scheduler->run();
  183. /* Schedule itself back in if it has more work. */
  184. /* Again, might as well assert on this mandatory scheduler_t function. If it
  185. * doesn't exist, there's no way to tell libevent to run the scheduler again
  186. * in the future. */
  187. tor_assert(the_scheduler->schedule);
  188. the_scheduler->schedule();
  189. }
  190. /*****************************************************************************
  191. * Scheduling system private function definitions
  192. *
  193. * Functions that can only be accessed from scheduler*.c
  194. *****************************************************************************/
  195. /** Return the pending channel list. */
  196. smartlist_t *
  197. get_channels_pending(void)
  198. {
  199. return channels_pending;
  200. }
  201. /** Comparison function to use when sorting pending channels. */
  202. MOCK_IMPL(int,
  203. scheduler_compare_channels, (const void *c1_v, const void *c2_v))
  204. {
  205. const channel_t *c1 = NULL, *c2 = NULL;
  206. /* These are a workaround for -Wbad-function-cast throwing a fit */
  207. const circuitmux_policy_t *p1, *p2;
  208. uintptr_t p1_i, p2_i;
  209. tor_assert(c1_v);
  210. tor_assert(c2_v);
  211. c1 = (const channel_t *)(c1_v);
  212. c2 = (const channel_t *)(c2_v);
  213. if (c1 != c2) {
  214. if (circuitmux_get_policy(c1->cmux) ==
  215. circuitmux_get_policy(c2->cmux)) {
  216. /* Same cmux policy, so use the mux comparison */
  217. return circuitmux_compare_muxes(c1->cmux, c2->cmux);
  218. } else {
  219. /*
  220. * Different policies; not important to get this edge case perfect
  221. * because the current code never actually gives different channels
  222. * different cmux policies anyway. Just use this arbitrary but
  223. * definite choice.
  224. */
  225. p1 = circuitmux_get_policy(c1->cmux);
  226. p2 = circuitmux_get_policy(c2->cmux);
  227. p1_i = (uintptr_t)p1;
  228. p2_i = (uintptr_t)p2;
  229. return (p1_i < p2_i) ? -1 : 1;
  230. }
  231. } else {
  232. /* c1 == c2, so always equal */
  233. return 0;
  234. }
  235. }
  236. /*****************************************************************************
  237. * Scheduling system global functions
  238. *
  239. * Functions that can be accessed from anywhere in Tor.
  240. *****************************************************************************/
  241. /** Using the global options, select the scheduler we should be using. */
  242. static void
  243. select_scheduler(void)
  244. {
  245. const char *chosen_sched_type = NULL;
  246. #ifdef TOR_UNIT_TESTS
  247. /* This is hella annoying to set in the options for every test that passes
  248. * through the scheduler and there are many so if we don't explicitly have
  249. * a list of types set, just put the vanilla one. */
  250. if (get_options()->SchedulerTypes_ == NULL) {
  251. the_scheduler = get_vanilla_scheduler();
  252. return;
  253. }
  254. #endif /* defined(TOR_UNIT_TESTS) */
  255. /* This list is ordered that is first entry has the first priority. Thus, as
  256. * soon as we find a scheduler type that we can use, we use it and stop. */
  257. SMARTLIST_FOREACH_BEGIN(get_options()->SchedulerTypes_, int *, type) {
  258. switch (*type) {
  259. case SCHEDULER_VANILLA:
  260. the_scheduler = get_vanilla_scheduler();
  261. chosen_sched_type = "Vanilla";
  262. goto end;
  263. case SCHEDULER_KIST:
  264. if (!scheduler_can_use_kist()) {
  265. #ifdef HAVE_KIST_SUPPORT
  266. if (get_options()->KISTSchedRunInterval == -1) {
  267. log_info(LD_SCHED, "Scheduler type KIST can not be used. It is "
  268. "disabled because KISTSchedRunInterval=-1");
  269. } else {
  270. log_notice(LD_SCHED, "Scheduler type KIST has been disabled by "
  271. "the consensus.");
  272. }
  273. #else /* !(defined(HAVE_KIST_SUPPORT)) */
  274. log_info(LD_SCHED, "Scheduler type KIST not built in");
  275. #endif /* defined(HAVE_KIST_SUPPORT) */
  276. continue;
  277. }
  278. the_scheduler = get_kist_scheduler();
  279. chosen_sched_type = "KIST";
  280. scheduler_kist_set_full_mode();
  281. goto end;
  282. case SCHEDULER_KIST_LITE:
  283. chosen_sched_type = "KISTLite";
  284. the_scheduler = get_kist_scheduler();
  285. scheduler_kist_set_lite_mode();
  286. goto end;
  287. default:
  288. /* Our option validation should have caught this. */
  289. tor_assert_unreached();
  290. }
  291. } SMARTLIST_FOREACH_END(type);
  292. end:
  293. log_notice(LD_CONFIG, "Scheduler type %s has been enabled.",
  294. chosen_sched_type);
  295. }
  296. /**
  297. * Helper function called from a few different places. It changes the
  298. * scheduler implementation, if necessary. And if it did, it then tells the
  299. * old one to free its state and the new one to initialize.
  300. */
  301. static void
  302. set_scheduler(void)
  303. {
  304. const scheduler_t *old_scheduler = the_scheduler;
  305. /* From the options, select the scheduler type to set. */
  306. select_scheduler();
  307. if (old_scheduler != the_scheduler) {
  308. /* Allow the old scheduler to clean up, if needed. */
  309. if (old_scheduler && old_scheduler->free_all) {
  310. old_scheduler->free_all();
  311. }
  312. /* Initialize the new scheduler. */
  313. if (the_scheduler->init) {
  314. the_scheduler->init();
  315. }
  316. }
  317. }
  318. /**
  319. * This is how the scheduling system is notified of Tor's configuration
  320. * changing. For example: a SIGHUP was issued.
  321. */
  322. void
  323. scheduler_conf_changed(void)
  324. {
  325. /* Let the scheduler decide what it should do. */
  326. set_scheduler();
  327. /* Then tell the (possibly new) scheduler that we have new options. */
  328. if (the_scheduler->on_new_options) {
  329. the_scheduler->on_new_options();
  330. }
  331. }
  332. /**
  333. * Whenever we get a new consensus, this function is called.
  334. */
  335. void
  336. scheduler_notify_networkstatus_changed(const networkstatus_t *old_c,
  337. const networkstatus_t *new_c)
  338. {
  339. /* Maybe the consensus param made us change the scheduler. */
  340. set_scheduler();
  341. /* Then tell the (possibly new) scheduler that we have a new consensus */
  342. if (the_scheduler->on_new_consensus) {
  343. the_scheduler->on_new_consensus(old_c, new_c);
  344. }
  345. }
  346. /**
  347. * Free everything scheduling-related from main.c. Note this is only called
  348. * when Tor is shutting down, while scheduler_t->free_all() is called both when
  349. * Tor is shutting down and when we are switching schedulers.
  350. */
  351. void
  352. scheduler_free_all(void)
  353. {
  354. log_debug(LD_SCHED, "Shutting down scheduler");
  355. if (run_sched_ev) {
  356. if (event_del(run_sched_ev) < 0) {
  357. log_warn(LD_BUG, "Problem deleting run_sched_ev");
  358. }
  359. tor_event_free(run_sched_ev);
  360. run_sched_ev = NULL;
  361. }
  362. if (channels_pending) {
  363. /* We don't have ownership of the objects in this list. */
  364. smartlist_free(channels_pending);
  365. channels_pending = NULL;
  366. }
  367. if (the_scheduler && the_scheduler->free_all) {
  368. the_scheduler->free_all();
  369. }
  370. the_scheduler = NULL;
  371. }
  372. /** Mark a channel as no longer ready to accept writes. */
  373. MOCK_IMPL(void,
  374. scheduler_channel_doesnt_want_writes,(channel_t *chan))
  375. {
  376. IF_BUG_ONCE(!chan) {
  377. return;
  378. }
  379. IF_BUG_ONCE(!channels_pending) {
  380. return;
  381. }
  382. /* If it's already in pending, we can put it in waiting_to_write */
  383. if (chan->scheduler_state == SCHED_CHAN_PENDING) {
  384. /*
  385. * It's in channels_pending, so it shouldn't be in any of
  386. * the other lists. It can't write any more, so it goes to
  387. * channels_waiting_to_write.
  388. */
  389. smartlist_pqueue_remove(channels_pending,
  390. scheduler_compare_channels,
  391. offsetof(channel_t, sched_heap_idx),
  392. chan);
  393. chan->scheduler_state = SCHED_CHAN_WAITING_TO_WRITE;
  394. log_debug(LD_SCHED,
  395. "Channel " U64_FORMAT " at %p went from pending "
  396. "to waiting_to_write",
  397. U64_PRINTF_ARG(chan->global_identifier), chan);
  398. } else {
  399. /*
  400. * It's not in pending, so it can't become waiting_to_write; it's
  401. * either not in any of the lists (nothing to do) or it's already in
  402. * waiting_for_cells (remove it, can't write any more).
  403. */
  404. if (chan->scheduler_state == SCHED_CHAN_WAITING_FOR_CELLS) {
  405. chan->scheduler_state = SCHED_CHAN_IDLE;
  406. log_debug(LD_SCHED,
  407. "Channel " U64_FORMAT " at %p left waiting_for_cells",
  408. U64_PRINTF_ARG(chan->global_identifier), chan);
  409. }
  410. }
  411. }
  412. /** Mark a channel as having waiting cells. */
  413. MOCK_IMPL(void,
  414. scheduler_channel_has_waiting_cells,(channel_t *chan))
  415. {
  416. IF_BUG_ONCE(!chan) {
  417. return;
  418. }
  419. IF_BUG_ONCE(!channels_pending) {
  420. return;
  421. }
  422. /* First, check if it's also writeable */
  423. if (chan->scheduler_state == SCHED_CHAN_WAITING_FOR_CELLS) {
  424. /*
  425. * It's in channels_waiting_for_cells, so it shouldn't be in any of
  426. * the other lists. It has waiting cells now, so it goes to
  427. * channels_pending.
  428. */
  429. chan->scheduler_state = SCHED_CHAN_PENDING;
  430. smartlist_pqueue_add(channels_pending,
  431. scheduler_compare_channels,
  432. offsetof(channel_t, sched_heap_idx),
  433. chan);
  434. log_debug(LD_SCHED,
  435. "Channel " U64_FORMAT " at %p went from waiting_for_cells "
  436. "to pending",
  437. U64_PRINTF_ARG(chan->global_identifier), chan);
  438. /* If we made a channel pending, we potentially have scheduling work to
  439. * do. */
  440. the_scheduler->schedule();
  441. } else {
  442. /*
  443. * It's not in waiting_for_cells, so it can't become pending; it's
  444. * either not in any of the lists (we add it to waiting_to_write)
  445. * or it's already in waiting_to_write or pending (we do nothing)
  446. */
  447. if (!(chan->scheduler_state == SCHED_CHAN_WAITING_TO_WRITE ||
  448. chan->scheduler_state == SCHED_CHAN_PENDING)) {
  449. chan->scheduler_state = SCHED_CHAN_WAITING_TO_WRITE;
  450. log_debug(LD_SCHED,
  451. "Channel " U64_FORMAT " at %p entered waiting_to_write",
  452. U64_PRINTF_ARG(chan->global_identifier), chan);
  453. }
  454. }
  455. }
  456. /** Add the scheduler event to the set of pending events with next_run being
  457. * the longest time libevent should wait before triggering the event. */
  458. void
  459. scheduler_ev_add(const struct timeval *next_run)
  460. {
  461. tor_assert(run_sched_ev);
  462. tor_assert(next_run);
  463. if (BUG(event_add(run_sched_ev, next_run) < 0)) {
  464. log_warn(LD_SCHED, "Adding to libevent failed. Next run time was set to: "
  465. "%ld.%06ld", next_run->tv_sec, (long)next_run->tv_usec);
  466. return;
  467. }
  468. }
  469. /** Make the scheduler event active with the given flags. */
  470. void
  471. scheduler_ev_active(int flags)
  472. {
  473. tor_assert(run_sched_ev);
  474. event_active(run_sched_ev, flags, 1);
  475. }
  476. /*
  477. * Initialize everything scheduling-related from config.c. Note this is only
  478. * called when Tor is starting up, while scheduler_t->init() is called both
  479. * when Tor is starting up and when we are switching schedulers.
  480. */
  481. void
  482. scheduler_init(void)
  483. {
  484. log_debug(LD_SCHED, "Initting scheduler");
  485. // Two '!' because we really do want to check if the pointer is non-NULL
  486. IF_BUG_ONCE(!!run_sched_ev) {
  487. log_warn(LD_SCHED, "We should not already have a libevent scheduler event."
  488. "I'll clean the old one up, but this is odd.");
  489. tor_event_free(run_sched_ev);
  490. run_sched_ev = NULL;
  491. }
  492. run_sched_ev = tor_event_new(tor_libevent_get_base(), -1,
  493. 0, scheduler_evt_callback, NULL);
  494. channels_pending = smartlist_new();
  495. set_scheduler();
  496. }
  497. /*
  498. * If a channel is going away, this is how the scheduling system is informed
  499. * so it can do any freeing necessary. This ultimately calls
  500. * scheduler_t->on_channel_free() so the current scheduler can release any
  501. * state specific to this channel.
  502. */
  503. MOCK_IMPL(void,
  504. scheduler_release_channel,(channel_t *chan))
  505. {
  506. IF_BUG_ONCE(!chan) {
  507. return;
  508. }
  509. IF_BUG_ONCE(!channels_pending) {
  510. return;
  511. }
  512. if (chan->scheduler_state == SCHED_CHAN_PENDING) {
  513. if (smartlist_pos(channels_pending, chan) == -1) {
  514. log_warn(LD_SCHED, "Scheduler asked to release channel %" PRIu64 " "
  515. "but it wasn't in channels_pending",
  516. chan->global_identifier);
  517. } else {
  518. smartlist_pqueue_remove(channels_pending,
  519. scheduler_compare_channels,
  520. offsetof(channel_t, sched_heap_idx),
  521. chan);
  522. }
  523. }
  524. if (the_scheduler->on_channel_free) {
  525. the_scheduler->on_channel_free(chan);
  526. }
  527. chan->scheduler_state = SCHED_CHAN_IDLE;
  528. }
  529. /** Mark a channel as ready to accept writes */
  530. void
  531. scheduler_channel_wants_writes(channel_t *chan)
  532. {
  533. IF_BUG_ONCE(!chan) {
  534. return;
  535. }
  536. IF_BUG_ONCE(!channels_pending) {
  537. return;
  538. }
  539. /* If it's already in waiting_to_write, we can put it in pending */
  540. if (chan->scheduler_state == SCHED_CHAN_WAITING_TO_WRITE) {
  541. /*
  542. * It can write now, so it goes to channels_pending.
  543. */
  544. log_debug(LD_SCHED, "chan=%" PRIu64 " became pending",
  545. chan->global_identifier);
  546. smartlist_pqueue_add(channels_pending,
  547. scheduler_compare_channels,
  548. offsetof(channel_t, sched_heap_idx),
  549. chan);
  550. chan->scheduler_state = SCHED_CHAN_PENDING;
  551. log_debug(LD_SCHED,
  552. "Channel " U64_FORMAT " at %p went from waiting_to_write "
  553. "to pending",
  554. U64_PRINTF_ARG(chan->global_identifier), chan);
  555. /* We just made a channel pending, we have scheduling work to do. */
  556. the_scheduler->schedule();
  557. } else {
  558. /*
  559. * It's not in SCHED_CHAN_WAITING_TO_WRITE, so it can't become pending;
  560. * it's either idle and goes to WAITING_FOR_CELLS, or it's a no-op.
  561. */
  562. if (!(chan->scheduler_state == SCHED_CHAN_WAITING_FOR_CELLS ||
  563. chan->scheduler_state == SCHED_CHAN_PENDING)) {
  564. chan->scheduler_state = SCHED_CHAN_WAITING_FOR_CELLS;
  565. log_debug(LD_SCHED,
  566. "Channel " U64_FORMAT " at %p entered waiting_for_cells",
  567. U64_PRINTF_ARG(chan->global_identifier), chan);
  568. }
  569. }
  570. }
  571. #ifdef TOR_UNIT_TESTS
  572. /*
  573. * Notify scheduler that a channel's queue position may have changed.
  574. */
  575. void
  576. scheduler_touch_channel(channel_t *chan)
  577. {
  578. IF_BUG_ONCE(!chan) {
  579. return;
  580. }
  581. if (chan->scheduler_state == SCHED_CHAN_PENDING) {
  582. /* Remove and re-add it */
  583. smartlist_pqueue_remove(channels_pending,
  584. scheduler_compare_channels,
  585. offsetof(channel_t, sched_heap_idx),
  586. chan);
  587. smartlist_pqueue_add(channels_pending,
  588. scheduler_compare_channels,
  589. offsetof(channel_t, sched_heap_idx),
  590. chan);
  591. }
  592. /* else no-op, since it isn't in the queue */
  593. }
  594. #endif /* defined(TOR_UNIT_TESTS) */