cpuworker.c 18 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601
  1. /* Copyright (c) 2003-2004, Roger Dingledine.
  2. * Copyright (c) 2004-2006, Roger Dingledine, Nick Mathewson.
  3. * Copyright (c) 2007-2018, The Tor Project, Inc. */
  4. /* See LICENSE for licensing information */
  5. /**
  6. * \file cpuworker.c
  7. * \brief Uses the workqueue/threadpool code to farm CPU-intensive activities
  8. * out to subprocesses.
  9. *
  10. * The multithreading backend for this module is in workqueue.c; this module
  11. * specializes workqueue.c.
  12. *
  13. * Right now, we use this infrastructure
  14. * <ul><li>for processing onionskins in onion.c
  15. * <li>for compressing consensuses in consdiffmgr.c,
  16. * <li>and for calculating diffs and compressing them in consdiffmgr.c.
  17. * </ul>
  18. **/
  19. #include "core/or/or.h"
  20. #include "core/or/channel.h"
  21. #include "core/or/circuitbuild.h"
  22. #include "core/or/circuitlist.h"
  23. #include "core/or/connection_or.h"
  24. #include "app/config/config.h"
  25. #include "core/mainloop/cpuworker.h"
  26. #include "lib/crypt_ops/crypto_rand.h"
  27. #include "lib/crypt_ops/crypto_util.h"
  28. #include "core/mainloop/main.h"
  29. #include "core/or/onion.h"
  30. #include "feature/relay/onion_queue.h"
  31. #include "feature/stats/rephist.h"
  32. #include "feature/relay/router.h"
  33. #include "lib/evloop/workqueue.h"
  34. #include "core/crypto/onion_crypto.h"
  35. #include "core/or/or_circuit_st.h"
  36. #include "lib/intmath/weakrng.h"
  37. static void queue_pending_tasks(void);
  38. typedef struct worker_state_s {
  39. int generation;
  40. server_onion_keys_t *onion_keys;
  41. } worker_state_t;
  42. static void *
  43. worker_state_new(void *arg)
  44. {
  45. worker_state_t *ws;
  46. (void)arg;
  47. ws = tor_malloc_zero(sizeof(worker_state_t));
  48. ws->onion_keys = server_onion_keys_new();
  49. return ws;
  50. }
  51. #define worker_state_free(ws) \
  52. FREE_AND_NULL(worker_state_t, worker_state_free_, (ws))
  53. static void
  54. worker_state_free_(worker_state_t *ws)
  55. {
  56. if (!ws)
  57. return;
  58. server_onion_keys_free(ws->onion_keys);
  59. tor_free(ws);
  60. }
  61. static void
  62. worker_state_free_void(void *arg)
  63. {
  64. worker_state_free_(arg);
  65. }
  66. static replyqueue_t *replyqueue = NULL;
  67. static threadpool_t *threadpool = NULL;
  68. static tor_weak_rng_t request_sample_rng = TOR_WEAK_RNG_INIT;
  69. static int total_pending_tasks = 0;
  70. static int max_pending_tasks = 128;
  71. /** Initialize the cpuworker subsystem. It is OK to call this more than once
  72. * during Tor's lifetime.
  73. */
  74. void
  75. cpu_init(void)
  76. {
  77. if (!replyqueue) {
  78. replyqueue = replyqueue_new(0);
  79. }
  80. if (!threadpool) {
  81. /*
  82. In our threadpool implementation, half the threads are permissive and
  83. half are strict (when it comes to running lower-priority tasks). So we
  84. always make sure we have at least two threads, so that there will be at
  85. least one thread of each kind.
  86. */
  87. const int n_threads = get_num_cpus(get_options()) + 1;
  88. threadpool = threadpool_new(n_threads,
  89. replyqueue,
  90. worker_state_new,
  91. worker_state_free_void,
  92. NULL);
  93. int r = threadpool_register_reply_event(threadpool, NULL);
  94. tor_assert(r == 0);
  95. }
  96. /* Total voodoo. Can we make this more sensible? */
  97. max_pending_tasks = get_num_cpus(get_options()) * 64;
  98. crypto_seed_weak_rng(&request_sample_rng);
  99. }
  100. /** Magic numbers to make sure our cpuworker_requests don't grow any
  101. * mis-framing bugs. */
  102. #define CPUWORKER_REQUEST_MAGIC 0xda4afeed
  103. #define CPUWORKER_REPLY_MAGIC 0x5eedf00d
  104. /** A request sent to a cpuworker. */
  105. typedef struct cpuworker_request_t {
  106. /** Magic number; must be CPUWORKER_REQUEST_MAGIC. */
  107. uint32_t magic;
  108. /** Flag: Are we timing this request? */
  109. unsigned timed : 1;
  110. /** If we're timing this request, when was it sent to the cpuworker? */
  111. struct timeval started_at;
  112. /** A create cell for the cpuworker to process. */
  113. create_cell_t create_cell;
  114. /* Turn the above into a tagged union if needed. */
  115. } cpuworker_request_t;
  116. /** A reply sent by a cpuworker. */
  117. typedef struct cpuworker_reply_t {
  118. /** Magic number; must be CPUWORKER_REPLY_MAGIC. */
  119. uint32_t magic;
  120. /** True iff we got a successful request. */
  121. uint8_t success;
  122. /** Are we timing this request? */
  123. unsigned int timed : 1;
  124. /** What handshake type was the request? (Used for timing) */
  125. uint16_t handshake_type;
  126. /** When did we send the request to the cpuworker? */
  127. struct timeval started_at;
  128. /** Once the cpuworker received the request, how many microseconds did it
  129. * take? (This shouldn't overflow; 4 billion micoseconds is over an hour,
  130. * and we'll never have an onion handshake that takes so long.) */
  131. uint32_t n_usec;
  132. /** Output of processing a create cell
  133. *
  134. * @{
  135. */
  136. /** The created cell to send back. */
  137. created_cell_t created_cell;
  138. /** The keys to use on this circuit. */
  139. uint8_t keys[CPATH_KEY_MATERIAL_LEN];
  140. /** Input to use for authenticating introduce1 cells. */
  141. uint8_t rend_auth_material[DIGEST_LEN];
  142. } cpuworker_reply_t;
  143. typedef struct cpuworker_job_u {
  144. or_circuit_t *circ;
  145. union {
  146. cpuworker_request_t request;
  147. cpuworker_reply_t reply;
  148. } u;
  149. } cpuworker_job_t;
  150. static workqueue_reply_t
  151. update_state_threadfn(void *state_, void *work_)
  152. {
  153. worker_state_t *state = state_;
  154. worker_state_t *update = work_;
  155. server_onion_keys_free(state->onion_keys);
  156. state->onion_keys = update->onion_keys;
  157. update->onion_keys = NULL;
  158. worker_state_free(update);
  159. ++state->generation;
  160. return WQ_RPL_REPLY;
  161. }
  162. /** Called when the onion key has changed so update all CPU worker(s) with
  163. * new function pointers with which a new state will be generated.
  164. */
  165. void
  166. cpuworkers_rotate_keyinfo(void)
  167. {
  168. if (!threadpool) {
  169. /* If we're a client, then we won't have cpuworkers, and we won't need
  170. * to tell them to rotate their state.
  171. */
  172. return;
  173. }
  174. if (threadpool_queue_update(threadpool,
  175. worker_state_new,
  176. update_state_threadfn,
  177. worker_state_free_void,
  178. NULL)) {
  179. log_warn(LD_OR, "Failed to queue key update for worker threads.");
  180. }
  181. }
  182. /** Indexed by handshake type: how many onionskins have we processed and
  183. * counted of that type? */
  184. static uint64_t onionskins_n_processed[MAX_ONION_HANDSHAKE_TYPE+1];
  185. /** Indexed by handshake type, corresponding to the onionskins counted in
  186. * onionskins_n_processed: how many microseconds have we spent in cpuworkers
  187. * processing that kind of onionskin? */
  188. static uint64_t onionskins_usec_internal[MAX_ONION_HANDSHAKE_TYPE+1];
  189. /** Indexed by handshake type, corresponding to onionskins counted in
  190. * onionskins_n_processed: how many microseconds have we spent waiting for
  191. * cpuworkers to give us answers for that kind of onionskin?
  192. */
  193. static uint64_t onionskins_usec_roundtrip[MAX_ONION_HANDSHAKE_TYPE+1];
  194. /** If any onionskin takes longer than this, we clip them to this
  195. * time. (microseconds) */
  196. #define MAX_BELIEVABLE_ONIONSKIN_DELAY (2*1000*1000)
  197. /** Return true iff we'd like to measure a handshake of type
  198. * <b>onionskin_type</b>. Call only from the main thread. */
  199. static int
  200. should_time_request(uint16_t onionskin_type)
  201. {
  202. /* If we've never heard of this type, we shouldn't even be here. */
  203. if (onionskin_type > MAX_ONION_HANDSHAKE_TYPE)
  204. return 0;
  205. /* Measure the first N handshakes of each type, to ensure we have a
  206. * sample */
  207. if (onionskins_n_processed[onionskin_type] < 4096)
  208. return 1;
  209. /** Otherwise, measure with P=1/128. We avoid doing this for every
  210. * handshake, since the measurement itself can take a little time. */
  211. return tor_weak_random_one_in_n(&request_sample_rng, 128);
  212. }
  213. /** Return an estimate of how many microseconds we will need for a single
  214. * cpuworker to process <b>n_requests</b> onionskins of type
  215. * <b>onionskin_type</b>. */
  216. uint64_t
  217. estimated_usec_for_onionskins(uint32_t n_requests, uint16_t onionskin_type)
  218. {
  219. if (onionskin_type > MAX_ONION_HANDSHAKE_TYPE) /* should be impossible */
  220. return 1000 * (uint64_t)n_requests;
  221. if (PREDICT_UNLIKELY(onionskins_n_processed[onionskin_type] < 100)) {
  222. /* Until we have 100 data points, just asssume everything takes 1 msec. */
  223. return 1000 * (uint64_t)n_requests;
  224. } else {
  225. /* This can't overflow: we'll never have more than 500000 onionskins
  226. * measured in onionskin_usec_internal, and they won't take anything near
  227. * 1 sec each, and we won't have anything like 1 million queued
  228. * onionskins. But that's 5e5 * 1e6 * 1e6, which is still less than
  229. * UINT64_MAX. */
  230. return (onionskins_usec_internal[onionskin_type] * n_requests) /
  231. onionskins_n_processed[onionskin_type];
  232. }
  233. }
  234. /** Compute the absolute and relative overhead of using the cpuworker
  235. * framework for onionskins of type <b>onionskin_type</b>.*/
  236. static int
  237. get_overhead_for_onionskins(uint32_t *usec_out, double *frac_out,
  238. uint16_t onionskin_type)
  239. {
  240. uint64_t overhead;
  241. *usec_out = 0;
  242. *frac_out = 0.0;
  243. if (onionskin_type > MAX_ONION_HANDSHAKE_TYPE) /* should be impossible */
  244. return -1;
  245. if (onionskins_n_processed[onionskin_type] == 0 ||
  246. onionskins_usec_internal[onionskin_type] == 0 ||
  247. onionskins_usec_roundtrip[onionskin_type] == 0)
  248. return -1;
  249. overhead = onionskins_usec_roundtrip[onionskin_type] -
  250. onionskins_usec_internal[onionskin_type];
  251. *usec_out = (uint32_t)(overhead / onionskins_n_processed[onionskin_type]);
  252. *frac_out = ((double)overhead) / onionskins_usec_internal[onionskin_type];
  253. return 0;
  254. }
  255. /** If we've measured overhead for onionskins of type <b>onionskin_type</b>,
  256. * log it. */
  257. void
  258. cpuworker_log_onionskin_overhead(int severity, int onionskin_type,
  259. const char *onionskin_type_name)
  260. {
  261. uint32_t overhead;
  262. double relative_overhead;
  263. int r;
  264. r = get_overhead_for_onionskins(&overhead, &relative_overhead,
  265. onionskin_type);
  266. if (!overhead || r<0)
  267. return;
  268. log_fn(severity, LD_OR,
  269. "%s onionskins have averaged %u usec overhead (%.2f%%) in "
  270. "cpuworker code ",
  271. onionskin_type_name, (unsigned)overhead, relative_overhead*100);
  272. }
  273. /** Handle a reply from the worker threads. */
  274. static void
  275. cpuworker_onion_handshake_replyfn(void *work_)
  276. {
  277. cpuworker_job_t *job = work_;
  278. cpuworker_reply_t rpl;
  279. or_circuit_t *circ = NULL;
  280. tor_assert(total_pending_tasks > 0);
  281. --total_pending_tasks;
  282. /* Could avoid this, but doesn't matter. */
  283. memcpy(&rpl, &job->u.reply, sizeof(rpl));
  284. tor_assert(rpl.magic == CPUWORKER_REPLY_MAGIC);
  285. if (rpl.timed && rpl.success &&
  286. rpl.handshake_type <= MAX_ONION_HANDSHAKE_TYPE) {
  287. /* Time how long this request took. The handshake_type check should be
  288. needless, but let's leave it in to be safe. */
  289. struct timeval tv_end, tv_diff;
  290. int64_t usec_roundtrip;
  291. tor_gettimeofday(&tv_end);
  292. timersub(&tv_end, &rpl.started_at, &tv_diff);
  293. usec_roundtrip = ((int64_t)tv_diff.tv_sec)*1000000 + tv_diff.tv_usec;
  294. if (usec_roundtrip >= 0 &&
  295. usec_roundtrip < MAX_BELIEVABLE_ONIONSKIN_DELAY) {
  296. ++onionskins_n_processed[rpl.handshake_type];
  297. onionskins_usec_internal[rpl.handshake_type] += rpl.n_usec;
  298. onionskins_usec_roundtrip[rpl.handshake_type] += usec_roundtrip;
  299. if (onionskins_n_processed[rpl.handshake_type] >= 500000) {
  300. /* Scale down every 500000 handshakes. On a busy server, that's
  301. * less impressive than it sounds. */
  302. onionskins_n_processed[rpl.handshake_type] /= 2;
  303. onionskins_usec_internal[rpl.handshake_type] /= 2;
  304. onionskins_usec_roundtrip[rpl.handshake_type] /= 2;
  305. }
  306. }
  307. }
  308. circ = job->circ;
  309. log_debug(LD_OR,
  310. "Unpacking cpuworker reply %p, circ=%p, success=%d",
  311. job, circ, rpl.success);
  312. if (circ->base_.magic == DEAD_CIRCUIT_MAGIC) {
  313. /* The circuit was supposed to get freed while the reply was
  314. * pending. Instead, it got left for us to free so that we wouldn't freak
  315. * out when the job->circ field wound up pointing to nothing. */
  316. log_debug(LD_OR, "Circuit died while reply was pending. Freeing memory.");
  317. circ->base_.magic = 0;
  318. tor_free(circ);
  319. goto done_processing;
  320. }
  321. circ->workqueue_entry = NULL;
  322. if (TO_CIRCUIT(circ)->marked_for_close) {
  323. /* We already marked this circuit; we can't call it open. */
  324. log_debug(LD_OR,"circuit is already marked.");
  325. goto done_processing;
  326. }
  327. if (rpl.success == 0) {
  328. log_debug(LD_OR,
  329. "decoding onionskin failed. "
  330. "(Old key or bad software.) Closing.");
  331. circuit_mark_for_close(TO_CIRCUIT(circ), END_CIRC_REASON_TORPROTOCOL);
  332. goto done_processing;
  333. }
  334. if (onionskin_answer(circ,
  335. &rpl.created_cell,
  336. (const char*)rpl.keys, sizeof(rpl.keys),
  337. rpl.rend_auth_material) < 0) {
  338. log_warn(LD_OR,"onionskin_answer failed. Closing.");
  339. circuit_mark_for_close(TO_CIRCUIT(circ), END_CIRC_REASON_INTERNAL);
  340. goto done_processing;
  341. }
  342. log_debug(LD_OR,"onionskin_answer succeeded. Yay.");
  343. done_processing:
  344. memwipe(&rpl, 0, sizeof(rpl));
  345. memwipe(job, 0, sizeof(*job));
  346. tor_free(job);
  347. queue_pending_tasks();
  348. }
  349. /** Implementation function for onion handshake requests. */
  350. static workqueue_reply_t
  351. cpuworker_onion_handshake_threadfn(void *state_, void *work_)
  352. {
  353. worker_state_t *state = state_;
  354. cpuworker_job_t *job = work_;
  355. /* variables for onion processing */
  356. server_onion_keys_t *onion_keys = state->onion_keys;
  357. cpuworker_request_t req;
  358. cpuworker_reply_t rpl;
  359. memcpy(&req, &job->u.request, sizeof(req));
  360. tor_assert(req.magic == CPUWORKER_REQUEST_MAGIC);
  361. memset(&rpl, 0, sizeof(rpl));
  362. const create_cell_t *cc = &req.create_cell;
  363. created_cell_t *cell_out = &rpl.created_cell;
  364. struct timeval tv_start = {0,0}, tv_end;
  365. int n;
  366. rpl.timed = req.timed;
  367. rpl.started_at = req.started_at;
  368. rpl.handshake_type = cc->handshake_type;
  369. if (req.timed)
  370. tor_gettimeofday(&tv_start);
  371. n = onion_skin_server_handshake(cc->handshake_type,
  372. cc->onionskin, cc->handshake_len,
  373. onion_keys,
  374. cell_out->reply,
  375. rpl.keys, CPATH_KEY_MATERIAL_LEN,
  376. rpl.rend_auth_material);
  377. if (n < 0) {
  378. /* failure */
  379. log_debug(LD_OR,"onion_skin_server_handshake failed.");
  380. memset(&rpl, 0, sizeof(rpl));
  381. rpl.success = 0;
  382. } else {
  383. /* success */
  384. log_debug(LD_OR,"onion_skin_server_handshake succeeded.");
  385. cell_out->handshake_len = n;
  386. switch (cc->cell_type) {
  387. case CELL_CREATE:
  388. cell_out->cell_type = CELL_CREATED; break;
  389. case CELL_CREATE2:
  390. cell_out->cell_type = CELL_CREATED2; break;
  391. case CELL_CREATE_FAST:
  392. cell_out->cell_type = CELL_CREATED_FAST; break;
  393. default:
  394. tor_assert(0);
  395. return WQ_RPL_SHUTDOWN;
  396. }
  397. rpl.success = 1;
  398. }
  399. rpl.magic = CPUWORKER_REPLY_MAGIC;
  400. if (req.timed) {
  401. struct timeval tv_diff;
  402. int64_t usec;
  403. tor_gettimeofday(&tv_end);
  404. timersub(&tv_end, &tv_start, &tv_diff);
  405. usec = ((int64_t)tv_diff.tv_sec)*1000000 + tv_diff.tv_usec;
  406. if (usec < 0 || usec > MAX_BELIEVABLE_ONIONSKIN_DELAY)
  407. rpl.n_usec = MAX_BELIEVABLE_ONIONSKIN_DELAY;
  408. else
  409. rpl.n_usec = (uint32_t) usec;
  410. }
  411. memcpy(&job->u.reply, &rpl, sizeof(rpl));
  412. memwipe(&req, 0, sizeof(req));
  413. memwipe(&rpl, 0, sizeof(req));
  414. return WQ_RPL_REPLY;
  415. }
  416. /** Take pending tasks from the queue and assign them to cpuworkers. */
  417. static void
  418. queue_pending_tasks(void)
  419. {
  420. or_circuit_t *circ;
  421. create_cell_t *onionskin = NULL;
  422. while (total_pending_tasks < max_pending_tasks) {
  423. circ = onion_next_task(&onionskin);
  424. if (!circ)
  425. return;
  426. if (assign_onionskin_to_cpuworker(circ, onionskin) < 0)
  427. log_info(LD_OR,"assign_to_cpuworker failed. Ignoring.");
  428. }
  429. }
  430. /** DOCDOC */
  431. MOCK_IMPL(workqueue_entry_t *,
  432. cpuworker_queue_work,(workqueue_priority_t priority,
  433. workqueue_reply_t (*fn)(void *, void *),
  434. void (*reply_fn)(void *),
  435. void *arg))
  436. {
  437. tor_assert(threadpool);
  438. return threadpool_queue_work_priority(threadpool,
  439. priority,
  440. fn,
  441. reply_fn,
  442. arg);
  443. }
  444. /** Try to tell a cpuworker to perform the public key operations necessary to
  445. * respond to <b>onionskin</b> for the circuit <b>circ</b>.
  446. *
  447. * Return 0 if we successfully assign the task, or -1 on failure.
  448. */
  449. int
  450. assign_onionskin_to_cpuworker(or_circuit_t *circ,
  451. create_cell_t *onionskin)
  452. {
  453. workqueue_entry_t *queue_entry;
  454. cpuworker_job_t *job;
  455. cpuworker_request_t req;
  456. int should_time;
  457. tor_assert(threadpool);
  458. if (!circ->p_chan) {
  459. log_info(LD_OR,"circ->p_chan gone. Failing circ.");
  460. tor_free(onionskin);
  461. return -1;
  462. }
  463. if (total_pending_tasks >= max_pending_tasks) {
  464. log_debug(LD_OR,"No idle cpuworkers. Queuing.");
  465. if (onion_pending_add(circ, onionskin) < 0) {
  466. tor_free(onionskin);
  467. return -1;
  468. }
  469. return 0;
  470. }
  471. if (!channel_is_client(circ->p_chan))
  472. rep_hist_note_circuit_handshake_assigned(onionskin->handshake_type);
  473. should_time = should_time_request(onionskin->handshake_type);
  474. memset(&req, 0, sizeof(req));
  475. req.magic = CPUWORKER_REQUEST_MAGIC;
  476. req.timed = should_time;
  477. memcpy(&req.create_cell, onionskin, sizeof(create_cell_t));
  478. tor_free(onionskin);
  479. if (should_time)
  480. tor_gettimeofday(&req.started_at);
  481. job = tor_malloc_zero(sizeof(cpuworker_job_t));
  482. job->circ = circ;
  483. memcpy(&job->u.request, &req, sizeof(req));
  484. memwipe(&req, 0, sizeof(req));
  485. ++total_pending_tasks;
  486. queue_entry = threadpool_queue_work_priority(threadpool,
  487. WQ_PRI_HIGH,
  488. cpuworker_onion_handshake_threadfn,
  489. cpuworker_onion_handshake_replyfn,
  490. job);
  491. if (!queue_entry) {
  492. log_warn(LD_BUG, "Couldn't queue work on threadpool");
  493. tor_free(job);
  494. return -1;
  495. }
  496. log_debug(LD_OR, "Queued task %p (qe=%p, circ=%p)",
  497. job, queue_entry, job->circ);
  498. circ->workqueue_entry = queue_entry;
  499. return 0;
  500. }
  501. /** If <b>circ</b> has a pending handshake that hasn't been processed yet,
  502. * remove it from the worker queue. */
  503. void
  504. cpuworker_cancel_circ_handshake(or_circuit_t *circ)
  505. {
  506. cpuworker_job_t *job;
  507. if (circ->workqueue_entry == NULL)
  508. return;
  509. job = workqueue_entry_cancel(circ->workqueue_entry);
  510. if (job) {
  511. /* It successfully cancelled. */
  512. memwipe(job, 0xe0, sizeof(*job));
  513. tor_free(job);
  514. tor_assert(total_pending_tasks > 0);
  515. --total_pending_tasks;
  516. /* if (!job), this is done in cpuworker_onion_handshake_replyfn. */
  517. circ->workqueue_entry = NULL;
  518. }
  519. }