Furthermore, fix a test that could returned an uninitialized value. Signed-off-by: David Goulet <dgoulet@torproject.org>
@@ -4511,7 +4511,7 @@ oos_victim_comparator_for_orconns(or_connection_t *a, or_connection_t *b)
b_circs = connection_or_get_num_circuits(b);
if (a_circs < b_circs) return -1;
- else if (b_circs > a_circs) return 1;
+ else if (a_circs > b_circs) return 1;
else return 0;
}
@@ -67,7 +67,7 @@ static int pick_oos_mock_last_n = 0;
static smartlist_t *
pick_oos_victims_mock(int n)
{
- smartlist_t *l;
+ smartlist_t *l = NULL;
int i;
++pick_oos_mock_calls;